Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extraction of Globals.prefs.put and .get #7121

Merged
merged 31 commits into from
Dec 14, 2020
Merged

Extraction of Globals.prefs.put and .get #7121

Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
87c0da9
Extracted Globals.prefs from SidePaneManager
calixtus Nov 21, 2020
c0566c4
Merge remote-tracking branch 'upstream/master' into refactor-globals-…
calixtus Nov 21, 2020
fd83cfe
Fixed failing tests
calixtus Nov 21, 2020
064e773
Extracted Globals.prefs from ClipBoardManager
calixtus Nov 21, 2020
edc04c6
Introduced GuiPreferences
calixtus Nov 21, 2020
1051c2c
Extracted prefs.get and put from ImportCommand and ExportCommand
calixtus Nov 22, 2020
eafc356
Extracted prefs.get and put from ExternalFileTypes
calixtus Nov 22, 2020
0f9301b
Extracted more prefs.get and put
calixtus Nov 22, 2020
ddfb805
Extracted more prefs.get and put from MergeEntries
calixtus Nov 22, 2020
bf36959
Extracted Globals.prefs.get and .put out of push package
calixtus Nov 29, 2020
0d03690
Merge remote-tracking branch 'upstream/master' into refactor-prefs-calls
Siedlerchr Dec 5, 2020
0d19091
Extrract calls to JabRefPreferences.getInstance()
Siedlerchr Dec 5, 2020
fb7e499
Extracted MrDlibPreferences, Fixed CrawlerTest, Removed some unnecess…
calixtus Dec 5, 2020
9f57e38
Fixed tests
calixtus Dec 7, 2020
9ee60c7
Merge remote-tracking branch 'upstream/master' into refactor-prefs-calls
calixtus Dec 7, 2020
85d0a6a
Fixed more tests
calixtus Dec 7, 2020
f2a62fd
Fixed NPEs in tests and checkstyle
calixtus Dec 7, 2020
426532b
l10n
calixtus Dec 7, 2020
ac6d4b5
Fixed NPE in CrawlerTest
calixtus Dec 7, 2020
9e85f9c
Cleanups
calixtus Dec 7, 2020
de26c7d
Merge remote-tracking branch 'upstream/master' into refactor-prefs-calls
calixtus Dec 7, 2020
eeb679b
Extracted TelemetryPreferences
calixtus Dec 7, 2020
43ced4c
Extracted calls to JabRefPreferences out of CustomImportList
calixtus Dec 8, 2020
7b56a94
Made storing of ProtectedTermsPreferences consistent
calixtus Dec 9, 2020
5a11a64
Extracted JabRefPreferences out ouf EntryEditor, reduced unnecessary …
calixtus Dec 9, 2020
2d15f61
Finished extracting unnecessary calls to JabRefPreferences
calixtus Dec 9, 2020
95882e5
Merge remote-tracking branch 'upstream/master' into refactor-prefs-calls
calixtus Dec 9, 2020
14d509d
l10n
calixtus Dec 9, 2020
465b180
Merge branch 'master' into refactor-prefs-calls
tobiasdiez Dec 13, 2020
abe7f4f
Fixed merge error
calixtus Dec 14, 2020
f1b16ce
Fix checkstyle
Siedlerchr Dec 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/jabref/gui/JabRefFrame.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,7 +817,7 @@ private MenuBar createMenu() {
new SeparatorMenuItem(),

factory.createMenuItem(StandardActions.SEND_AS_EMAIL, new SendAsEMailAction(dialogService, prefs, stateManager)),
pushToApplicationMenuItem,
pushToApplicationMenuItem
// Disabled until PR #7126 can be merged
// new SeparatorMenuItem(),
//factory.createMenuItem(StandardActions.START_SYSTEMATIC_LITERATURE_REVIEW,
Siedlerchr marked this conversation as resolved.
Show resolved Hide resolved
Expand Down