Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore 429 at link check #10743

Merged
merged 11 commits into from
Jan 3, 2024
Merged

Ignore 429 at link check #10743

merged 11 commits into from
Jan 3, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented Jan 3, 2024

Our link checker reports an error at http 429.

grafik

We should ignore it.

Sources:

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

calixtus
calixtus previously approved these changes Jan 3, 2024
View reviewed changes
@koppor koppor added the status: depends-on-external A bug or issue that depends on an update of an external library label Jan 3, 2024
@koppor
Copy link
Member Author

koppor commented Jan 3, 2024

I reverted the syntax, due to the range syntax not available in the released version (see lycheeverse/lychee#1329).

@koppor koppor removed the status: depends-on-external A bug or issue that depends on an update of an external library label Jan 3, 2024
@koppor koppor merged commit 350958f into main Jan 3, 2024
16 of 17 checks passed
@koppor koppor deleted the koppor-patch-1 branch January 3, 2024 12:31
Siedlerchr added a commit that referenced this pull request Jan 3, 2024
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fixDuplicateUmlauts
8217d5b 
* upstream/main:
  Ignore 429 at link check (#10743)
  Fix color for hovered special fields (#10742)

# Conflicts:
#	CHANGELOG.md
Siedlerchr added a commit that referenced this pull request Jan 3, 2024
@Siedlerchr
Merge branch 'main' of github.com:JabRef/jabref
ad80390 
* 'main' of github.com:JabRef/jabref:
  Ignore 429 at link check (#10743)
  Fix color for hovered special fields (#10742)
  Adds three tests to verify the expected output from the getErroMessage function. The tests check the output message when ParserResult is empty, not empty, or has duplicates. (#10711)
  Extract calls to JabRefFrame and substitute with LibraryTabContainer (#10724)
Siedlerchr added a commit that referenced this pull request Jan 12, 2024
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into allEntriesDuplicates
42774ed 
* upstream/main:
  Fix duplicate checker does not respect umlauts / latex free fields  (#10744)
  Ignore 429 at link check (#10743)
  Fix color for hovered special fields (#10742)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@calixtus calixtus calixtus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koppor @Siedlerchr @calixtus