Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate checker does not respect umlauts / latex free fields #10744

Merged
merged 4 commits into from
Jan 3, 2024
Merged

Fix duplicate checker does not respect umlauts / latex free fields #10744

merged 4 commits into from
Jan 3, 2024

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Jan 3, 2024 •
edited
Loading

Fixes https://github.com/JabRef/jabref-issue-melting-pot/issues/249

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr force-pushed the fixDuplicateUmlauts branch from 26e745a to 1fb8e0f Compare January 3, 2024 15:52
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 3, 2024
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fixDuplicateUmlauts
8217d5b 
* upstream/main:
  Ignore 429 at link check (#10743)
  Fix color for hovered special fields (#10742)

# Conflicts:
#	CHANGELOG.md
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr Siedlerchr enabled auto-merge January 3, 2024 17:31
@Siedlerchr Siedlerchr added this pull request to the merge queue Jan 3, 2024
Merged via the queue into main with commit bd92577 Jan 3, 2024
18 checks passed
@Siedlerchr Siedlerchr deleted the fixDuplicateUmlauts branch January 3, 2024 19:16
Siedlerchr added a commit that referenced this pull request Jan 12, 2024
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into allEntriesDuplicates
42774ed 
* upstream/main:
  Fix duplicate checker does not respect umlauts / latex free fields  (#10744)
  Ignore 429 at link check (#10743)
  Fix color for hovered special fields (#10742)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@calixtus calixtus calixtus approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Siedlerchr @calixtus