Extract calls to JabRefFrame and substitute with LibraryTabContainer #10724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SharedDatabaseCommand
calixtus
added
status: ready-for-review
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
tobiasdiez
approved these changes
Dec 31, 2023
| } | ||
|
|
||
| frame.getCurrentLibraryTab().markBaseChanged(); | ||
| tabSupplier.get().markBaseChanged(); |
There was a problem hiding this comment.
It looks like most of the remaining usages of the LibraryTab are now related to the "changed" status. Is it easy to push this down to the database context (as a follow-up of course)?
There was a problem hiding this comment.
We'll see. My plan is to somehow really fix the undo redo stuff and for that I want to utilize the commands we're using and maybe putting them eventually on a reactive stream. But there is still some road to walk.
Upmost next is some refactoring of libraryTab and jabrefframe
Siedlerchr
added a commit
that referenced
this pull request
Jan 3, 2024
* 'main' of github.com:JabRef/jabref: Ignore 429 at link check (#10743) Fix color for hovered special fields (#10742) Adds three tests to verify the expected output from the getErroMessage function. The tests check the output message when ParserResult is empty, not empty, or has duplicates. (#10711) Extract calls to JabRefFrame and substitute with LibraryTabContainer (#10724)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)