Added tests to verify proper output from getErrorMessage() #10711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e function. The tests check the output message when ParserResult is empty, not empty, or has duplicates.
|
Thank you for the first tests. There should also be tests for invalid BibTeX files. Maybe, you can add some minimal examples of non-working BibTeX files? (This is also very hard and time consuming to craft, but a good excercise) |
|
Okay I will give it a shot. |
|
Happy new year 🎉🎉. To reduce the number of opened PRs, I'll go ahead with merge. You are welcome to craft a follow-up PR if you want. |
koppor
approved these changes
Jan 2, 2024
Siedlerchr
added a commit
that referenced
this pull request
Jan 3, 2024
* 'main' of github.com:JabRef/jabref: Ignore 429 at link check (#10743) Fix color for hovered special fields (#10742) Adds three tests to verify the expected output from the getErroMessage function. The tests check the output message when ParserResult is empty, not empty, or has duplicates. (#10711) Extract calls to JabRefFrame and substitute with LibraryTabContainer (#10724)
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were added as requested from the conversation in the merged pull request #10700. The three tests added aim to verify the correct output from the getErrorMessage function. Specifically when the ParserResult is empty, not empty, or has duplicate messages added,
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)