-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(engine): fix color contrast for text with graphic background and update role and attribute allowances for body/search/button/input/summary/li elements per ARIA in HTML updates #1432
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombrunet
previously approved these changes
May 9, 2023
Sync dev branch dev-1336 to dev-1304
Sync dev branch dev-1301 to dev-1304
Sync dev branch dev-1202 to dev-1304
This was referenced May 11, 2023
Merged
tombrunet
approved these changes
May 12, 2023
shunguoy
changed the title
feature(engine): update for role allowances for button/input button elements per ARIA in HTML updates
feature(engine): fix color contrast for text with graphic background and update role and attribute allowances for body/search/button/input/summary/li elements per ARIA in HTML updates
May 12, 2023
shunguoy
changed the title
feature(engine): fix color contrast for text with graphic background and update role and attribute allowances for body/search/button/input/summary/li elements per ARIA in HTML updates
fix(engine): fix color contrast for text with graphic background and update role and attribute allowances for body/search/button/input/summary/li elements per ARIA in HTML updates
May 15, 2023
The ticket have been validated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the following issue(s):
#1304
Note for the test: the following PRs were merged to this PR: #1413, #1407, and #1405. The test should be done in this branch for all tests in the other PRs and related issues. See individual PR for the issues and test cases.
Additional information can be found here:
Testing reference:
test/v2/checker/accessibility/rules/HAAC_Aria_Native_Host_Semantics_ruleunit/elementsWithSupportingAttributes.html
I have conducted the following for this PR: