Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): fix color contrast for text with graphic background and update role and attribute allowances for body/search/button/input/summary/li elements per ARIA in HTML updates #1432

Merged
merged 38 commits into from
May 15, 2023

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented May 4, 2023

  • Rule bug: HAAC_Aria_Native_Host_Semantics

This PR is related to the following issue(s):

#1304
Note for the test: the following PRs were merged to this PR: #1413, #1407, and #1405. The test should be done in this branch for all tests in the other PRs and related issues. See individual PR for the issues and test cases.

Additional information can be found here:

Testing reference:

test/v2/checker/accessibility/rules/HAAC_Aria_Native_Host_Semantics_ruleunit/elementsWithSupportingAttributes.html

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@shunguoy shunguoy requested a review from tombrunet May 8, 2023 15:20
@shunguoy shunguoy marked this pull request as ready for review May 8, 2023 15:20
tombrunet
tombrunet previously approved these changes May 9, 2023
@shunguoy shunguoy changed the title feature(engine): update for role allowances for button/input button elements per ARIA in HTML updates feature(engine): fix color contrast for text with graphic background and update role and attribute allowances for body/search/button/input/summary/li elements per ARIA in HTML updates May 12, 2023
@shunguoy shunguoy changed the title feature(engine): fix color contrast for text with graphic background and update role and attribute allowances for body/search/button/input/summary/li elements per ARIA in HTML updates fix(engine): fix color contrast for text with graphic background and update role and attribute allowances for body/search/button/input/summary/li elements per ARIA in HTML updates May 15, 2023
@ErickRenteria
Copy link
Contributor

The ticket have been validated.

@ErickRenteria ErickRenteria merged commit cceecfc into master May 15, 2023
@shunguoy shunguoy deleted the dev-1304 branch August 11, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants