Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): fix color contrast issues for text with image/gradient background or shadow #1405

Merged
merged 13 commits into from
May 15, 2023

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Apr 19, 2023

  • Rule bug: IBMA_Color_Contrast_WCAG2AA IBMA_Color_Contrast_WCAG2AA_PV

This PR is related to the following issue(s):

#1201 #1202 #1203 #1205

Additional information can be found here:

Testing reference:

note that this branch was merged with the branch dev-1304 in PR #1432. The test should be done using the branch dev-1304 and with the following test cases.

  1. test/v2/checker/accessibility/rules/IBMA_Color_Contrast_WCAG2AA_ruleunit/act_pass_4.html (now is reported as a potential violation, rather than violation). test/v2/checker/accessibility/rules/IBMA_Color_Contrast_WCAG2AA_ruleunit/act_pass_7.html, test/v2/checker/accessibility/rules/IBMA_Color_Contrast_WCAG2AA_ruleunit/special-chars-1.html
  2. test/v2/checker/accessibility/rules/IBMA_Color_Contrast_WCAG2AA_ruleunit/*.html. please note the rule IBMA_Color_Contrast_WCAG2AA_PV was merged to IBMA_Color_Contrast_WCAG2AA, make sure all the issues, previously reported in the two rules, are still reported.
  3. the major fix is to eliminate the exceptions during the build (the exceptions don't cause build errors).

I have conducted the following for this PR:

  • [ x] I validated this code in Chrome and FF
  • [x ] I validated this fix in my local env
  • [x ] I provided details for testing
  • This PR has been reviewed and is ready for test
  • [ x] I understand that the title of this PR will be used for the next release notes.

@shunguoy shunguoy requested a review from tombrunet April 19, 2023 19:09
@shunguoy shunguoy marked this pull request as ready for review April 19, 2023 19:09
tombrunet
tombrunet previously approved these changes Apr 26, 2023
@ErickRenteria
Copy link
Contributor

  1. Tested with equal-access/accessibility-checker-engine/test/v2/checker/accessibility/rules/Rpt_Aria_RequiredParent_Native_Host_Sematics_ruleunit/ACT_ff89c9_pass4.html No changes. @shunguoy

@shunguoy
Copy link
Contributor Author

@ErickRenteria looks like you got the wrong test case: Tested with equal-access/accessibility-checker-engine/test/v2/checker/accessibility/rules/Rpt_Aria_RequiredParent_Native_Host_Sematics_ruleunit/ACT_ff89c9_pass4.html.
Please see the "Testing Reference" section for the correct test cases. Note that the "IBMA_Color_Contrast_WCAG2AA" was renamed to "ext_contrast_sufficient" so the file paths need to be renamed accordingly.

@ErickRenteria
Copy link
Contributor

Validated with accessibility-checker-engine/test/v2/checker/accessibility/rules/text_contrast_sufficient_ruleunit/act_pass_7.html

@ErickRenteria ErickRenteria merged commit bc7a65a into master May 15, 2023
@tombrunet tombrunet deleted the dev-1202 branch August 15, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants