Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): fix color contrast for text with graphic background and update role and attribute allowances for body/search/button/input/summary/li elements per ARIA in HTML updates #1432

Merged
merged 38 commits into from
May 15, 2023
Merged

fix(engine): fix color contrast for text with graphic background and update role and attribute allowances for body/search/button/input/summary/li elements per ARIA in HTML updates #1432

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
7f43ca8
update the color logic #1202
shunguoy Apr 6, 2023
23792e7
add additional message to the color contrast rule #1202
shunguoy Apr 11, 2023
bbb8233
merge two color contrast rules and update test cases #1202
shunguoy Apr 11, 2023
3668b74
update color contrast rule #1202
shunguoy Apr 12, 2023
1abe939
update color contrast rule to fix graphic background issue #1202
shunguoy Apr 14, 2023
c30396a
update the rule for special characters #1202
shunguoy Apr 18, 2023
6f1651e
update color contrast rule for special characters #1202
shunguoy Apr 18, 2023
3e832c5
add potential violation for text shadow #1202
shunguoy Apr 18, 2023
f8af3fa
Merge branch 'master' into dev-1202
shunguoy Apr 19, 2023
bd64483
update the baselines #1202
shunguoy Apr 19, 2023
68c5b8e
update rule and test case #1336
shunguoy Apr 20, 2023
602a5ad
add search element support #1336
shunguoy Apr 20, 2023
7d5fe1b
Merge branch 'master' into dev-1336
shunguoy Apr 21, 2023
9ba2144
test cases #1301
shunguoy Apr 24, 2023
845c562
create test cases #1301
shunguoy Apr 26, 2023
7a28084
Merge branch 'master' into dev-1202
ErickRenteria Apr 28, 2023
48759a9
Merge branch 'master' into dev-1336
shunguoy Apr 28, 2023
2e093cf
Merge branch 'master' into dev-1301
shunguoy Apr 28, 2023
476bf68
update role support #1301
shunguoy Apr 28, 2023
73ded94
update test results #1301
shunguoy May 1, 2023
502033f
add test cases for li and update rule logic #1301
shunguoy May 1, 2023
f4bc86f
update aria definition #1304
shunguoy May 4, 2023
332dcff
test cases and test results #1304
shunguoy May 5, 2023
80192f4
Merge branch 'master' into dev-1202
tombrunet May 10, 2023
710ba30
Fix rules in test cases
tombrunet May 10, 2023
cef6c8b
Merge branch 'master' into dev-1336
tombrunet May 10, 2023
affb46a
Merge branch 'master' into dev-1301
tombrunet May 10, 2023
3daecbe
Merge branch 'master' into dev-1304
tombrunet May 10, 2023
4a66b6e
Merge pull request #1442 from IBMa/dev-1336
shunguoy May 11, 2023
0ee725c
Merge pull request #1441 from IBMa/dev-1301
shunguoy May 11, 2023
bc7a65a
Merge pull request #1443 from IBMa/dev-1202
shunguoy May 11, 2023
69e81cb
Merge branch 'master' into dev-1304
shunguoy May 11, 2023
0aa61e1
update test results #1304
shunguoy May 11, 2023
028b405
update test cases #1304
shunguoy May 11, 2023
db0d038
update test cases #1304
shunguoy May 11, 2023
af9628e
update the baselines #1304
shunguoy May 12, 2023
d3a6486
remove obsolete test cases #1304
shunguoy May 12, 2023
554c3d0
Merge branch 'master' into dev-1304
ErickRenteria May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions accessibility-checker-engine/src/v2/aria/ARIADefinitions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1720,7 +1720,7 @@ export class ARIADefinitions {
},
"button": {
implicitRole: ["button"],
validRoles: ["checkbox", "combobox", "link", "menuitem", "menuitemcheckbox", "menuitemradio", "option", "radio", "switch", "tab"],
validRoles: ["checkbox", "combobox", "gridcell", "link", "menuitem", "menuitemcheckbox", "menuitemradio", "option", "radio", "slider", "switch", "tab", "treeitem"],
globalAriaAttributesValid: true
},
"canvas": {
Expand Down Expand Up @@ -2294,7 +2294,7 @@ export class ARIADefinitions {
"input": {
"button": {
implicitRole: ["button"],
validRoles: ["checkbox", "combobox", "link", "menuitem", "menuitemcheckbox", "menuitemradio", "option", "radio", "switch", "tab"],
validRoles: ["checkbox", "combobox", "gridcell", "link", "menuitem", "menuitemcheckbox", "menuitemradio", "option", "radio", "slider", "switch", "tab", "treeitem"],
globalAriaAttributesValid: true
},
"checkbox-with-aria-pressed": {
Expand Down Expand Up @@ -2358,7 +2358,7 @@ export class ARIADefinitions {
},
"image": {
implicitRole: ["button"],
validRoles: ["link", "menuitem", "menuitemcheckbox", "menuitemradio", "radio", "switch"],
validRoles: ["checkbox", "gridcell", "link", "menuitem", "menuitemcheckbox", "menuitemradio", "option", "radio", "slider", "switch", "tab", "treeitem"],
globalAriaAttributesValid: true
},
"month": {
Expand Down Expand Up @@ -2396,7 +2396,7 @@ export class ARIADefinitions {
},
"reset": {
implicitRole: ["button"],
validRoles: null,
validRoles: ["checkbox", "combobox", "gridcell", "link", "menuitem", "menuitemcheckbox", "menuitemradio", "option", "radio", "slider", "switch", "tab", "treeitem"],
globalAriaAttributesValid: true
},
"search-no-list": {
Expand All @@ -2412,7 +2412,7 @@ export class ARIADefinitions {
},
"submit": {
implicitRole: ["button"],
validRoles: null,
validRoles: ["checkbox", "combobox", "gridcell", "link", "menuitem", "menuitemcheckbox", "menuitemradio", "option", "radio", "slider", "switch", "tab", "treeitem"],
globalAriaAttributesValid: true
},
"tel-no-list": {
Expand Down
32 changes: 26 additions & 6 deletions ...lity/rules/HAAC_Aria_Native_Host_Semantics_ruleunit/elementsWithSupportingAttributes.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,21 +575,41 @@ <h2 role="heading" aria-label="h2_El" id="h2_El2" aria-level="1"> Heading level
"ruleId": "aria_semantics_role",
"value": [
"INFORMATION",
"FAIL"
"PASS"
],
"path": {
"dom": "/html[1]/body[1]/div[1]/button[3]",
"aria": "/document[1]/generic[1]/region[1]/slider[1]"
},
"reasonId": "Fail_1",
"message": "The ARIA role 'slider' is not valid for the element <button>",
"reasonId": "Pass_0",
"message": "Rule Passed",
"messageArgs": [
"slider",
"button"
],
"apiArgs": [],
"category": "Accessibility"
},
{
"ruleId": "aria_attribute_allowed",
"value": [
"INFORMATION",
"FAIL"
],
"path": {
"dom": "/html[1]/body[1]/div[1]/button[3]",
"aria": "/document[1]/generic[1]/region[1]/slider[1]"
},
"reasonId": "Fail_invalid_role_attr",
"message": "The ARIA attributes \"aria-expanded, aria-pressed\" are not valid for the element <button> with ARIA role \"slider\"",
"messageArgs": [
"aria-expanded, aria-pressed",
"button",
"slider"
],
"apiArgs": [],
"category": "Accessibility"
},
{
"ruleId": "aria_attribute_allowed",
"value": [
Expand Down Expand Up @@ -1159,14 +1179,14 @@ <h2 role="heading" aria-label="h2_El" id="h2_El2" aria-level="1"> Heading level
"ruleId": "aria_semantics_role",
"value": [
"INFORMATION",
"FAIL"
"PASS"
],
"path": {
"dom": "/html[1]/body[1]/div[1]/input[1]",
"aria": "/document[1]/generic[1]/region[1]/slider[4]"
},
"reasonId": "Fail_1",
"message": "The ARIA role 'slider' is not valid for the element <input>",
"reasonId": "Pass_0",
"message": "Rule Passed",
"messageArgs": [
"slider",
"input"
Expand Down
Loading