Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<fixrule(aria_attribute_allowed, aria_semantics_role)> disallow aria-hidden on body element and add support for the new search element #1407

Merged
merged 5 commits into from
May 15, 2023

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Apr 20, 2023

  • Rule bug: aria_attribute_allowed", "aria_semantics_role"

This PR is related to the following issue(s):

#1336 #1360

Additional information can be found here:

Testing reference:

note that this branch was merged with the branch dev-1304 in PR #1432. The test should be done using the branch dev-1304 and with the following test cases.

test/v2/checker/accessibility/rules/aria_semantics_role_ruleunit/body_attribute.html shows the new violation on the body element
test/v2/checker/accessibility/rules/aria_semantics_role_ruleunit/search_role_attribute.html shows the new violations on the search elements

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@shunguoy shunguoy changed the title <fixrule(aria_attribute_allowed)> disallow aria-hidden on body element <fixrule(aria_attribute_allowed)> disallow aria-hidden on body element and add support for the new search element Apr 20, 2023
@shunguoy shunguoy changed the title <fixrule(aria_attribute_allowed)> disallow aria-hidden on body element and add support for the new search element <fixrule(aria_attribute_allowed, aria_semantics_role)> disallow aria-hidden on body element and add support for the new search element Apr 21, 2023
@shunguoy shunguoy requested a review from tombrunet April 24, 2023 18:25
@shunguoy shunguoy marked this pull request as ready for review April 24, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants