Dead/broken formula cleanup. #37014
Dead/broken formula cleanup. #37014
Conversation
| @@ -2,8 +2,9 @@ | |||
|
|
|||
| class Dvorak7min < Formula | |||
| homepage 'http://dvorak7min.sourcearchive.com/' | |||
| url 'http://dvorak7min.sourcearchive.com/downloads/1.6.1-13.1/dvorak7min_1.6.1.orig.tar.gz' | |||
There was a problem hiding this comment.
This isn't 404, but downloads an empty file. The Debian repack addresses this.
| @@ -0,0 +1,10 @@ | |||
| class LibxmpLite < Formula | |||
There was a problem hiding this comment.
As @mistydemeo noted, this is the former "coremod". Add formula + alias.
There was a problem hiding this comment.
Unfortunately, for technical reasons we can't support formula renames. Mind doing this the other way around? E.g. add an alias under the libxmp-lite name, and leave the formula itself as coremod.
There was a problem hiding this comment.
Ugh... 😦.
Correct me if I misunderstand, but the "technical reason" is: any extant install of "coremod" would be effectively orphaned, i.e., since the coremod alias now always points to libxml-lite, there's no way to brew rm coremod on the old version, that command will always try to brew rm libxmp-lite.
My personal preference (in light of this) would be to revert back to "boneyarding" the coremod formula, while adding a new libxmp-lite formula. This actually seems a lot more prudent to me: given the fact that the libname has changed, "upgrading" coremod to libxmp-lite would probably cause breakage in anything dynamically linked to the old library. Plus, the formulae wouldn't conflict, since everything else has been renamed as well. Thoughts?
There was a problem hiding this comment.
I'm going ahead and pushing the changes I suggest above for now.
There was a problem hiding this comment.
If the library name has changed that seems a good reason to boneyard/new formula, yeh.
…udio and figtoipe to head-only. New source/update/repack: dvorak7min, gtk-gnutella, ipbt, libgadu, logcheck, mysql-cluster, sipsak, ssdb, unittest, vilistextum, yacas. Add libxmp-lite formula (former coremod).
| @@ -22,14 +22,17 @@ | |||
| "cmucl" => "homebrew/binary", | |||
| "comparepdf" => "homebrew/boneyard", | |||
| "connect" => "homebrew/boneyard", | |||
| "coremod" => "homebrew/boneyard", | |||
There was a problem hiding this comment.
I've gone ahead and put this back in boneyard, whilst adding the additional libxmp-lite formula.
|
It seems there are still gonna be some 'bot failures, but I wouldn't have a clue as to how to "test" libxmp-lite, etc. And surely even with some rubocop errors, better than getting 404s? |
See |
|
Please also split this up to follow the "one commit per formula, one formula per commit" guideline. Thanks. |
…a per commit" guideline.
…a per commit" guideline.
…a per commit" guideline.
…a per commit" guideline.
…a per commit" guideline.
…a per commit" guideline.
|
@jacknagel 😓 Done, as requested. @MikeMcQuaid I've added tests where it seemed feasible, including in the new libxmp-lite formula; apologies for the rest. |
…a per commit" guideline.
…a per commit" guideline.
|
Closing as redundant with the child PRs. |
|
👍 |
…a per commit" guideline.
…a per commit" guideline.
…a per commit" guideline.
…a per commit" guideline.
…a per commit" guideline.
I apologize for the "drive-by" PR. This is my follow up to #36430, a collection of fixes for formulae with source URLs that are either 404, or have bad checksums.
If any of these changes are controversial, I can try to split them out, or feel free to handle these differently if you see fit.
See corresponding PRs in head-only and boneyard.
Summary (also see line notes):
Rename coremod to libxmp-lite, add alias.