This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
vilistextum: fix 404. #37071
Closed
vilistextum: fix 404. #37071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note you can have multiple commits per pull request 😉 |
…a per commit" guideline.
geoff-nixon
force-pushed
the
vilistexum-fix-source
branch
from
541acab to
f0358c2
Compare
|
@bfontaine Still its frowned upon though, no? Back in the day, as I recall squashing commits was required. In fact, with these commit messages, I'm actually just quoting Mr. Nagel. 😉 |
|
I'm finding these a little easier to manage than a single giant PR but in general there's not a one-commit-per-PR rule. More specific commit messages would be helpful though! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #37014 per "one commit per formula, one formula per commit" guideline.