-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
Conversation
Only failing on Yosemite; doesn't look Java-related:
|
Well there is an undeclared Java dep... cmake fails with Apple's Java 6:
But I agree, I don't think that's the issue that's cropping up on the buildbot. There is a mirror of 7.3.4 at http://cdn.mysql.com/archives/mysql-cluster-gpl-7.3/mysql-cluster-gpl-7.3.4.tar.gz ...roll back to that instead? |
I just that older 7.3.4 on Yosemite and it failed with the same error. The last change to this formula was made just about at the same time 10.10 was released. Do we know if this ever built on Yosemite? |
We don't. If it doesn't we might want to add a |
ae157ba
to
d7fef44
Compare
sha1 "f70ac7955343765146c556576c8b13dbedf9c593" | ||
|
||
# Fix me: if you can get this to build on Yosemite, send a pull request! | ||
depends_on MaximumMacOSRequirement => :mavericks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added. This is the correct requirement to use, yes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to suggest changing homepage
to https://www.mysql.com/products/cluster/
(to avoid a redirect and to enable SSL) and url
to use SSL: https://dev.mysql.com/get/Downloads/MySQL-Cluster-7.3/mysql-cluster-gpl-7.3.8.tar.gz
d7fef44
to
6e66d3f
Compare
…a per commit" guideline.
6e66d3f
to
06a51ef
Compare
url 'http://mysql.llarian.net/Downloads/MySQL-Cluster-7.3/mysql-cluster-gpl-7.3.4.tar.gz' | ||
sha1 '01003903da6802885bc98565ebe07f76714488fe' | ||
homepage "https://www.mysql.com/products/cluster/" | ||
url "https://dev.mysql.com/get/Downloads/MySQL-Cluster-7.3/mysql-cluster-gpl-7.3.8.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vszakats URIs changed per your suggestion.
Thank you. |
Thanks @geoff-codes! |
Split out from #37014 per "one commit per formula, one formula per commit" guideline.
Still doesn't build for me though... I think there's an undeclared Java 7+ dep?