Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

ssdb: fix SHA (repack). #37068

Closed
wants to merge 1 commit into from
Closed

Conversation

geoff-nixon
Copy link
Contributor

Split out from #37014 per "one commit per formula, one formula per commit" guideline.

@tdsmith
Copy link
Contributor

tdsmith commented Feb 23, 2015

Can you share a diff/get an upstream comment?

@geoff-nixon
Copy link
Contributor Author

It looks like there was an additional patch added to https://github.com/ideawu/ssdb/commits/stable-1.8.0 after the initial 1.8.0: https://github.com/Homebrew/homebrew/commits/master/Library/Formula/ssdb.rb.

Bump rev?

@tdsmith
Copy link
Contributor

tdsmith commented Feb 23, 2015

Good detective work. Yeah, let's bump.

@geoff-nixon
Copy link
Contributor Author

Added revision 1.

head "https://github.com/ideawu/ssdb.git"
revision 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to revision this as it'll force everyone to reinstall it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, maybe in this case we do want to.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah Fix ssdb-dump memory leak sounds like a good thing.

@MikeMcQuaid
Copy link
Member

Thanks for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock!

For future reference the preferred commit message format for simple version updates is ssdb: fix SHA (repacked).

@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants