-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sqlite 3.32.1, dbhash 3.32.1, sqldiff 3.32.1, sqlite-analyzer 3.32.1 #55191
Conversation
|
I've done my due diligence with the CI failures and none of them seem related to this I don't imagine there's any benefit in kicking off another CI run and this is probably good to merge but it would be good for another maintainer to check my work. |
The deprecations should probably be addressed ASAP.
Usually means that we're waiting for a test that isn't killed properly. You can remove the TERM statements nowadays because brew will kill them in a more consistent way at the end of the test. |
percona-server probably needs a "conflicts-with" for protobuf based on the output. |
Looking through related formulae using
Gotcha, I'll create PRs to remove the relevant bits from the tests for
Any preferences on the text for Past that, do you think this PR should be blocked on these unrelated failures? |
There is an issue open for this from @Bo98
Sounds fine
I think if CI fails something must be done to make sure that doesn't happen again. Especially with test failures I'm a bit hasitant to just dismiss them. |
Alureplay's homepage has a link to a git repo which in turn has reference to a github repo. So I made an issue to ask if this is an official successor. EDIT: For dromeaudio I think it's time to mark it as disabled. If we can't get it to perform it's main function.... |
Does this have any impact on the test timeout? The test works fine for me locally and all it does is play a .wav file:
I commented on #55292 with some additional information and that may or may not impact the decision here. Outside of these two, the only other one that isn't being resolved in another PR is I don't think the failure is related to these |
Welp, sqlite 3.32.1 was apparently released in the interim time, so I'm going to update this PR and see what happens on CI this time around. |
The failures in this latest run will either be fixed in another PR ( CI failures across all macOS versions:
Additional failure for 10.13:
Additional failure for 10.15:
The libsoundio
Output
yafcThis failed due to the upstream Speedtest server. Output
|
👍 considering these are known failures. |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?