Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thefuck: fix test #55408

Closed
wants to merge 1 commit into from
Closed

thefuck: fix test #55408

wants to merge 1 commit into from

Conversation

samford
Copy link
Member

@samford samford commented May 28, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

The test for thefuck was failing on CI in a PR for a sqlite update (#55191), though this failure is unrelated. This test works fine for me locally using both the bottled version, when building from source, and when building from source with sqlite 3.32.0 built from source.

This PR currently just adds a comment (to create a change), so I can see if this fails on CI again and try to debug the test in that environment (since I can't reproduce this locally).

@samford
Copy link
Member Author

samford commented May 28, 2020

Of course it passed this time 😞

I'm going to leave this open for a bit, in case I need to do more testing here. I think we may just have to do another run of the sqlite PR eventually, after we've resolved all the issues we can.

Edit: This test didn't fail in the second run of the sqlite PR, so this can simply be closed for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant