Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nanomsg: remove process.kill/wait #55282

Merged
merged 1 commit into from
May 25, 2020

Conversation

samford
Copy link
Member

@samford samford commented May 25, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

This removes Process.kill/Process.wait from the test (since brew does its own killing these days), in hopes of avoiding the execution expired timeout (as seen in #55191).

@samford samford merged commit 21e48fc into Homebrew:master May 25, 2020
@samford samford deleted the nanomsg-remove-process-kill-wait branch May 25, 2020 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant