ungit: remove process.kill/wait

[samford]

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

This removes Process.kill/Process.wait from the test (since brew does its own killing these days), in hopes of avoiding the execution expired timeout (as seen in #55191).

[samford]

Unfortunately, we still need to resolve the AssertionFailedError.

==> FAILED
Testing ungit
/usr/bin/sandbox-exec -f /private/tmp/homebrew20200525-82270-w0879j.sb ruby -W0 -I $LOAD_PATH -- /usr/local/Homebrew/Library/Homebrew/test.rb /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/ungit.rb --verbose
==> curl -s 127.0.0.1:56668/

Killing child processes...
Error: ungit: failed
An exception occurred within a child process:
  Test::Unit::AssertionFailedError: <0> expected but was
<7>.

This test works fine locally but I can't yet see what the problem is on CI to be able to fix it (since print statements don't show up in the log).

[SMillerDev]

Try ohai instead and use ,7) in shell_output.

[SMillerDev]

I just looked up what 7 means for curl (CURLE_COULDNT_CONNECT (7)). It could very well be that it just needs to sleep a little longer to properly wait for the server.

[samford]

use ,7) in shell_output.

Oh yeah, I forgot that you have to resolve the assertion issue for print statements to actually print. p worked fine when I added , 7) in shell_output.

I just looked up what 7 means for curl (CURLE_COULDNT_CONNECT (7)). It could very well be that it just needs to sleep a little longer to properly wait for the server.

The output was just an empty string ("") when the test failed, so the error makes sense. I tried this with sleep 10 and it still failed in the same way.

Removing --autoShutdownTimeout=6000 seems to resolve the issue, even when using the existing 5 second sleep. I'm going to give this another run, to make sure it's not a fluke.

[samford]

It seems good, so I'm going to go ahead and merge. Thanks for your help, Sean.