-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to GitHub CI #1495
Change to GitHub CI #1495
Conversation
Documentation works at https://rikhuijzer.github.io/Gadfly2.jl/dev/. It also has a working favicon #1488. |
At this point, this branch seems to obtain the same CI outputs as the Travis configuration on |
LGTM. @Mattriks ? |
Codecov Report
@@ Coverage Diff @@
## master #1495 +/- ##
=======================================
Coverage 88.94% 88.94%
=======================================
Files 39 39
Lines 4395 4395
=======================================
Hits 3909 3909
Misses 486 486 Continue to review full report at Codecov.
|
@rikhuijzer the docs built successfully after #1505 was merged, but they do not seem to have been deployed. is that perhaps because CI failed for julia 1.0? anyway to change github CI to fix it? thanks. |
@bjarthur Hmm, I should have checked the logs earlier. When looking at the GitHub Actions logs for the change to GitHub Workflow merge [1] and the most recent merged PR [2], I see
So, it seems that 1: https://github.com/GiovineItalia/Gadfly.jl/runs/1397859352?check_suite_focus=true |
done. but it still didn't deploy:
|
It seems that Documenter still looks for Travis, which isn't the case for the CI repository I made at https://github.com/rikhuijzer/Gadfly2.jl, there it says:
Lets hope that a newer Documenter version solves it, and if not, go from there. |
Fixes #1494
Contributor checklist:
Proposed changes