Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Documenter version #1506

Merged
merged 1 commit into from
Dec 28, 2020
Merged

Bump Documenter version #1506

merged 1 commit into from
Dec 28, 2020

Conversation

rikhuijzer
Copy link
Contributor

In response to #1495. Lets bump Documenter.jl first. This is likely to solve the problem, and otherwise I'll look into it further.

@bjarthur bjarthur merged commit d78d866 into GiovineItalia:master Dec 28, 2020
@rikhuijzer
Copy link
Contributor Author

Awesome. It's fixed now because the log output is

┌ Info: Deployment criteria for deploying devbranch build from GitHub Actions:
│ - ✔ ENV["GITHUB_REPOSITORY"]="GiovineItalia/Gadfly.jl" occurs in repo="github.com/GiovineItalia/Gadfly.jl.git"
│ - ✔ ENV["GITHUB_EVENT_NAME"]="push" is "push"
│ - ✔ ENV["GITHUB_REF"] matches devbranch="master"
│ - ✔ ENV["GITHUB_ACTOR"] exists
│ - ✔ ENV["DOCUMENTER_KEY"] exists
└ Deploying: ✔

and http://gadflyjl.org/dev/ shows

Plots won't be automatically displayed in your default browser unless you tweak Base.Multimedia.displays to return the GadflyDisplay to the last entry

which was changed to this sentence in #1501.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants