Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom fixes #1505

Merged
merged 2 commits into from
Dec 20, 2020
Merged

Zoom fixes #1505

merged 2 commits into from
Dec 20, 2020

Conversation

blepabyte
Copy link
Contributor

Fixes #1504

Contributor checklist:

  • I've updated the documentation to reflect these changes
  • I've added an entry to NEWS.md
  • I've added and/or updated the unit tests
  • I've run the regression tests
  • I've squash'ed or fixup'ed junk commits with git-rebase
  • I've built the docs and confirmed these changes don't cause new errors

Proposed changes

  • The mousewheel and DOMMouseScroll events are deprecated (wheelDelta was undefined causing the NaN's) so I swapped to the wheel event, which has better browser support.
  • Made some changes to address the docs issue in Zooming in IJulia notebooks #1272 - I built the docs and zoom is now working on all the browsers I tested (additionally, the co-ordinates are now correct)
    • Plotting from REPL worked since the plot was always at the exact top-left corner of the page

This does not completely fix the original IJulia notebook problem in the linked issue (when shift left-click + dragging to zoom) as jupyter seems to do something weird with mouse events.

@bjarthur bjarthur merged commit 904078a into GiovineItalia:master Dec 20, 2020
@bjarthur
Copy link
Member

thanks!

@bjarthur bjarthur mentioned this pull request Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shift + scrolling to zoom in Firefox results in NaN values
2 participants