Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add favicon #1488

Merged
merged 1 commit into from
Oct 25, 2020
Merged

Add favicon #1488

merged 1 commit into from
Oct 25, 2020

Conversation

rikhuijzer
Copy link
Contributor

Contributor checklist:

  • I've updated the documentation to reflect these changes
  • I've added an entry to NEWS.md
  • I've added and/or updated the unit tests
  • I've run the regression tests
  • I've squash'ed or fixup'ed junk commits with git-rebase
  • I've built the docs and confirmed these changes don't cause new errors

Proposed changes

Often, I have the Gadfly documentation open in one of my browser tabs. Gadfly has a nice logo, but unfortunately it isn't shown as a favicon. This pull request adds a favicon.ico of 48x48 pixels, which is a scaled down version of docs/source/assets/logo.png of 500x500 pixels.

@rikhuijzer rikhuijzer changed the title Add favicon to documentation site Add favicon Oct 25, 2020
@bjarthur bjarthur merged commit 90185dc into GiovineItalia:master Oct 25, 2020
@bjarthur
Copy link
Member

thanks!

@rikhuijzer rikhuijzer mentioned this pull request Nov 13, 2020
Merged
@rikhuijzer rikhuijzer mentioned this pull request Mar 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rikhuijzer @bjarthur