Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v0.6.1.beta.1 #1764

Merged
merged 10 commits into from
Sep 4, 2024
Merged

Release v0.6.1.beta.1 #1764

merged 10 commits into from
Sep 4, 2024

Conversation

scottqueen-bixal
Copy link
Collaborator

PR Summary

Related Github Issue

Data improvements

Update crazyegg variable programatically #1755

Design improvements

Include all benefits icon #1739
DESIGN | Update Typography across application #1445

Application improvements

Error message not working on date fieldsets with out required flag #1737

Content improvements

UX Content Changes #1662

Detailed Testing steps

Data improvements

Update crazyegg variable programatically #1755

  • edit death of a loved one spanish/english life event to include the following in the Header field
<script id="bf-track-by-name" type="text/javascript">
  var CE_SNAPSHOT_NAME = "";
</script>
  • navigate to /death
  • find script in <head /> to ensure that it rendered

As you navigate through the app, we expect that the value assigned to CE_SNAPSHOT_NAME updates

this is how we will construct the name in the application

<script type="text/javascript">
    var CE_SNAPSHOT_NAME = "{pageView}-{life-event-id}-{desktop || mobile}";
</script>

for example

<script type="text/javascript">
    var CE_SNAPSHOT_NAME = "bf-form-1-disability-desktop";
</script>

So the values would look like this....

<!-- desktop values -->

bf-intro-disability-desktop
bf-form-1-disability-desktop
bf-form-2-disability-desktop
bf-form-completion-modal-disability-desktop
bf-verify-selections-disability-desktop
bf-result-eligible-view-disability-desktop
bf-result-not-eligible-view-disability-desktop

<!-- mobile values -->

bf-intro-disability-mobile
bf-form-1-disability-mobile
bf-form-2-disability-mobile
bf-form-completion-modal-disability-mobile
bf-verify-selections-disability-mobile
bf-result-eligible-view-disability-mobile
bf-result-not-eligible-view-disability-mobile

The current know life event ids are as follows,

death
es_death
 
disability
es_disability
 
retirement
es_retirement
 
all_benefits
es_all_benefits

Design improvements

Include all benefits icon #1739

  • publish all_benefits and es_all_benefits nodes
  • create a relevant benefits node for each, and reference them in death life event
  • complete the form and provide values for required fields
  • ensure the all benefits icon is displayed in both relative benefits cards

expected:

Screenshot 2024-08-28 at 6 43 05 PM

DESIGN | Update Typography across application #1445

  • navigate through /death

Expected view(s)
screencapture-localhost-benefit-finder-death-2024-08-27-10_10_14

screencapture-localhost-benefit-finder-death-2024-08-27-10_10_35

screencapture-localhost-benefit-finder-death-2024-08-27-10_11_06

Screenshot 2024-08-27 at 10 11 46 AM

screencapture-localhost-benefit-finder-death-2024-08-27-10_11_53

screencapture-localhost-benefit-finder-death-2024-08-27-10_12_13

screencapture-localhost-benefit-finder-death-2024-08-27-10_12_29

screencapture-localhost-benefit-finder-death-2024-08-27-10_12_59

Application Improvements

Error message not working on date fieldsets with out required flag #1737

  • pull changes locally
  • cd benefit-finder
  • update proxy url to point at our main bxdev env
  • npm run start
  • navigate to /death
  • CLICK continue without providing any values
  • ensure error alert is rendered
  • SELECT an option from a fieldset with <select /> input
  • ensure the error is cleared
  • SELECT the default option --Select-- from the now valid input
  • ensure the error is flagged and the DOM updates as expected

expected:

Screen.Recording.2024-08-30.at.10.08.22.AM.mov
  • publish all_benefits node
  • navigate to /all_benefits
  • on the first step of the form, SELECT a month value from the date fieldset
  • CLICK continue
  • ensure that the error alert is rendered
  • SELECT the default option --Select-- from the now invalid input
  • ensure that the error alert is cleared
  • CLICK continue
  • ensure that you can proceed to the next step
  • CLICK back to return to the first step
  • SELECT a month value from the date fieldset
  • CLICK continue
  • ensure that the error alert is rendered
  • SELECT the default option --Select-- from the now invalid input
  • ensure that the error alert is cleared
  • enter a day value to the date fieldset
  • CLCIK continue
  • ensure that the error alert is rendered

expected:

Screen.Recording.2024-08-30.at.10.15.21.AM.mov

Content improvements

UX Content Changes #1662

Current Suggested EN Suggested ES
Start Start finding benefits Encuentre sus beneficios
Continue Next Siguiente
Review selections Review your selections Revise sus respuestas
See results Get your results Obtenga sus resultados
Close all Expand all Abrir todos
See benefits you did not qualify for Explore other potential benefits Explore otros beneficios

Detailed Testing steps

  • navigate application and review content updates

expected:
Screenshot 2024-09-04 at 9 41 29 AM

Screenshot 2024-09-04 at 9 41 56 AM Screenshot 2024-09-04 at 9 42 39 AM Screenshot 2024-09-04 at 9 43 18 AM Screenshot 2024-09-04 at 10 15 49 AM

scottqueen-bixal and others added 10 commits June 27, 2024 12:48
@scottqueen-bixal
Merge pull request #1502 from GSA/dev
d00590b 
Release v0.5.0.beta.1
@XavierMetichecchia
Update database-restore.yml
b67a0b6
@scottqueen-bixal
Merge pull request #1546 from GSA/dev
a88f4a5 
Release v0.5.0.beta.1 (sprint 35)
@scottqueen-bixal
Merge pull request #1593 from GSA/dev
4d2e519 
Benefit Finder Release v0.5.0.beta.1 (Sprint 36)
@scottqueen-bixal
Merge pull request #1596 from GSA/dev
607eb13 
Benefit Finder Release v0.5.0 (Sprint 36) QA & Automated tests
@scottqueen-bixal
Merge pull request #1657 from GSA/dev
4e978ce 
v0.6.0.beta.1 (Sprint 37)
@scottqueen-bixal
Merge pull request #1686 from GSA/dev
f33a975 
v0.6.0.beta.1 (Sprint 38)
@scottqueen-bixal
Merge pull request #1709 from GSA/dev
1e35e98 
v0.6.0.beta.1 (Sprint 38)
@scottqueen-bixal
Merge pull request #1754 from GSA/dev
f9da1aa 
v0.6.1 (Sprint 39)
@scottqueen-bixal
Merge pull request #1763 from GSA/dev
9eb91ac 
Release v0.6.1.beta.1 (Sprint 39)
@scottqueen-bixal scottqueen-bixal self-assigned this Sep 4, 2024
@scottqueen-bixal scottqueen-bixal marked this pull request as ready for review September 4, 2024 14:59
@scottqueen-bixal scottqueen-bixal merged commit a797318 into dev Sep 4, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nehemiah-abuga nehemiah-abuga nehemiah-abuga approved these changes

@gchi25 gchi25 gchi25 approved these changes

Assignees

@scottqueen-bixal scottqueen-bixal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scottqueen-bixal @gchi25 @nehemiah-abuga @XavierMetichecchia