Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.6.0.beta.1 (Sprint 38) #1709

Merged
merged 47 commits into from
Aug 20, 2024
Merged

v0.6.0.beta.1 (Sprint 38) #1709

merged 47 commits into from
Aug 20, 2024

Conversation

scottqueen-bixal
Copy link
Collaborator

@scottqueen-bixal scottqueen-bixal commented Aug 19, 2024

PR Summary

Related Github Issue

Hide qualtrics survey, with exceptions #1701
update package version and dependencies #1687
QA | BUGFIX error dataLayer event #1684
setCurrent is not a prop in stepback back link #1681
memorable date id should only append month, year, or day to parent group id #1680
Increase space following a fieldset with error #1679
date field in memorable date doesn't recognize value 0 as error #1676
Submit dataLayer update if errorCount changes #1669
Benefit finder page level surveys #1638
Add search title in JSON data #1674

Detailed Testing Steps

Hide qualtrics survey, with exceptions #1701

  • ensure on page load that the survey div is in the DOM, bf-qual-survey with the hidden attribute is true
  • navigate to results view
  • ensure on page load that the survey div is in the DOM, bf-qual-survey with the hidden attribute is false
  • ensure that you can view the survey container, solid red outline

update package version and dependencies #1687

  • navigate to /death
  • inspect DOM
  • search for data-version
  • ensure version is 0.6.0.beta.1

date field in memorable date doesn't recognize value 0 as error #1676

  • navigate to /death
  • in the first step of the form, input 0 for the date field value of the first question
  • CLICK Continue
  • ensure that the day value indicates an error

Add search title in JSON data #1674

  • Navigate to admin/content?combine=&type=bears_life_event&status=All&langcode=All
  • Go to life event "Benefit finder: retirement" edit page
  • Add "Approaching retirement" in search title field
  • Save as published
  • Go to life event "Benefit finder: disability" edit page
  • Add "Living with a disability or illness" in search title field
  • Save as published
  • Navigate to benefit-finder/api/life-event/death
  • Verify searchTitle in json data

image

after generating json

  • navigate to "/benefit-finder/death`
  • complete required fields to get to Results view
  • ensure updated searchTitles are rendering in Relevant Benefits Cards
Screenshot 2024-08-20 at 10 44 51 AM

gchi25 and others added 27 commits August 15, 2024 09:10
PXBF-1676-invalidate-zero-day-date: set zero value days to invalid
@scottqueen-bixal scottqueen-bixal self-assigned this Aug 19, 2024
scottqueen-bixal and others added 18 commits August 19, 2024 16:30
@scottqueen-bixal scottqueen-bixal marked this pull request as ready for review August 20, 2024 17:40
@scottqueen-bixal scottqueen-bixal merged commit 1e35e98 into main Aug 20, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants