Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1674 add search title in json data #1678

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

gchi25
Copy link
Collaborator

@gchi25 gchi25 commented Aug 15, 2024

PR Summary

This work add search title in json data.

Related Github Issue

Detailed Testing steps

To test in local development site or in dev site.

  • In local, pull changes locally
  • In local, make local development site up at http://localhost
  • Navigate to admin/content?combine=&type=bears_life_event&status=All&langcode=All
  • Go to life event "Benefit finder: retirement" edit page
  • Add "Approaching retirement" in search title field
  • Save as published
  • Go to life event "Benefit finder: disability" edit page
  • Add "Living with a disability or illness" in search title field
  • Save as published
  • Navigate to benefit-finder/api/life-event/death
  • Verify searchTitle in json data

image

after generating json

  • navigate to "/benefit-finder/death`
  • complete required fields to get to Results view
  • ensure updated searchTitles are rendering in Relevant Benefits Cards
Screenshot 2024-08-20 at 10 44 51 AM

@gchi25 gchi25 self-assigned this Aug 15, 2024
@scottqueen-bixal
Copy link
Collaborator

Requirement is for the new key pair to be in the relevantBenefits Array Objects

Screenshot 2024-08-15 at 9 40 04 AM

@scottqueen-bixal scottqueen-bixal removed the request for review from nehemiah-abuga August 15, 2024 13:42
scottqueen-bixal

This comment was marked as duplicate.

Copy link
Collaborator

@scottqueen-bixal scottqueen-bixal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check location of key

@gchi25
Copy link
Collaborator Author

gchi25 commented Aug 19, 2024

Requirement is for the new key pair to be in the relevantBenefits Array Objects

Screenshot 2024-08-15 at 9 40 04 AM

Implemented.

@scottqueen-bixal
Copy link
Collaborator

I've included the update for consuming the new searchTitle with the title fall back in the application.

@scottqueen-bixal scottqueen-bixal mentioned this pull request Aug 20, 2024
24 tasks
@scottqueen-bixal scottqueen-bixal merged commit d806d06 into dev Aug 20, 2024
7 checks passed
@scottqueen-bixal scottqueen-bixal deleted the 1674-add-search-title-json-data branch August 20, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add search title in JSON data
2 participants