Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.5.0.beta.1 (sprint 35) #1546

Merged
merged 64 commits into from
Jul 10, 2024
Merged

Release v0.5.0.beta.1 (sprint 35) #1546

merged 64 commits into from
Jul 10, 2024

Conversation

scottqueen-bixal
Copy link
Collaborator

@scottqueen-bixal scottqueen-bixal commented Jul 10, 2024

PR Summary

Data Layer Improvements

Update accordion open data layer event names #1516
Create data layer push event for open all/close all accordion button on results pages #1515
Update pageView Data Layer variable #1514
Create data layer event to track benefit link click #1467
Add data layer value to track benefit accordion open #1466

UI Content Improvements

Zero Benefits Translation Content #1453

Custom module Improvements

Cannot delete life event form if still used #1521
Clean benefit finder configuration #1525
Disable json file generation in BF multi-content action #1338

Detailed Testing steps

Data Layer Improvements

Update accordion open data layer event names #1516

  • visit /benefit-finder/death
  • complete required fields, answer YES for all radio fields
  • on the results view, CLICK open an accordion
  • console.log(window.dataLayer)
  • ensure the event value is bf_accordion_open
Screenshot 2024-07-01 at 11 23 39 AM
  • close the same accordion
  • console.log(window.dataLayer)
  • ensure that a new event was not fired
  • CLICK open the accordion again, ensure that a new event was fired
  • toggle to not-eligible view
  • on the not-eligible results view, CLICK open an accordion
  • console.log(window.dataLayer)
  • ensure the event value is bf_accordion_open

Create data layer push event for open all/close all accordion button on results pages #1515

  • visit /benefit-finder/death
  • complete all required fields, select YES for all radio fields
  • on the results view, CLICK Open all +
  • console.log(window.dataLayer)
  • ensure that the bf_open_all_accordions event fires
  • ensure that bfData.accordionsOpen is true
  • on the results view, CLICK Close all +
  • console.log(window.dataLayer)
  • ensure that the bf_open_all_accordions event fires
  • console.log(window.dataLayer)
  • ensure that bfData.accordionsOpen is false

expected:

Screenshot 2024-07-01 at 12 24 35 PM

Update pageView Data Layer variable #1514

  • visit /benefit-finder/death
  • complete required fields, answering YES to all radios
  • console.log(window.dataLayer)
  • confirm bf_page_change event object has bfData.pageView value of "bf-result-eligible-view"
  • CLICK See benefits you did not qualify for button
  • console.log(window.dataLayer)
  • confirm bf_page_change event object has bfData.pageView value of "bf-result-not-eligible-view"

expected:
Screenshot 2024-07-01 at 9 45 44 AM

Create data layer event to track benefit link click #1467

  • navigate to /benefit-finder/death
  • complete required fields
  • answer YES to all radio fields
  • in the results CLICK a benefit accordion
  • in the open accordion click the button as a link, this should take you to an external site
  • return to the application and console.log(window.dataLayer)
  • confirm that the benefit you clicked is open and an"event": "bf_benefit_link", is in the dataLayer array that includes its title value
[
  ...
    {
        "event": "bf_benefit_link",
        "bfData": {
            "benefitTitle": "COVID-19 funeral assistance"
        }
    }
  ...
]

Add data layer value to track benefit accordion open #1466

  • navigate to /benefit-finder/death
  • complete required fields
  • answer YES to all radio fields
  • in the results CLICK a benefit accordion
  • console.log(window.dataLayer)
  • confirm that the benefit you clicked is open and an"event": "bf_benefit_click", is in the dataLayer array that includes its title value
[
   ...
    {
        "event": "bf_benefit_click",
        "bfData": {
            "benefitTitle": "COVID-19 funeral assistance"
        }
    },
]
  • CLICK the same benefit accordion to close it
  • console.log(window.dataLayer)
  • confirm that the benefit you clicked is closed and no new "event": "bf_benefit_click", is in the dataLayer array
  • CLICK the same benefit accordion to open it, and CLICK a secondary benefit to also open
  • console.log(window.dataLayer)
  • confirm that the two (2) benefit you clicked are open and an "event": "bf_benefit_click", is in the dataLayer array that includes its title value

New UI Content

Zero Benefits Translation Content #1453

  • navigate to /benefit-finder/death
  • navigate through application completing the required fields and answering "NO" to radio fields
  • ensure that the spanish content below is appearing as expected

key English Spanish
chevron.heading You are likely not eligible for these benefits. Usted parece no ser elegible para estos beneficios.
chevron.description If you reached these results by mistake, please go back to review your answers. Si cree que cometió un error, por favor regrese para corregir sus respuestas.
heading No eligible results. No tiene resultados elegibles.
description Based on your answers you are likely not eligible for benefits. You may become eligible if you enter more information or your situation changes. Basado en sus respuestas usted no es elegible para estos beneficios. Podría ser elegible si ingresa más información o si su situación cambia.
cta See all benefits Ver todos los beneficios

expected view

Screenshot 2024-06-27 at 12 29 51 PM

Custom module Improvements

Disable json file generation in BF multi-content action #1338

  • navigate to admin/content?combine=&type=bears_criteria&status=All&langcode=All
  • select several criteria
  • select "Publish content" in action list
  • click "Apply to selected items" button
  • verify that the system not generating json files
  • verify that the system displays warning message

Cannot delete life event form if still used #1521

  • Navigate to admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
  • Go to life event form "Benefit finder: death of a loved one" edit page
  • Click Delete
  • Verify the warning message "cannot delete the life event form" and list of life event forms
  • verify that no Delete confirmation button

image

  • Go to life event form "Benefit finder: retirement" edit page
  • Remove life event form "Benefit finder: death of a loved one" in relevant benefit
  • Click Save
  • Go to life event form "Benefit finder: disability" edit page
  • Remove life event form "Benefit finder: death of a loved one" in relevant benefit
  • Click Save

Now delete life event form "Benefit finder: death of a loved one" again

  • Go to life event form "Benefit finder: death of a loved one" edit page
  • Click Delete
  • Verify message "This action cannot be undone"
  • Verify message "The following entity references will be skipped and leave orphans" and list of benefits
  • Click Delete button to delete this life event form
  • Verify life event form "Benefit finder: death of a loved one" deleted

Clean benefit finder configuration #1525

This work removes benefit finder partial-configuration which has already been exported to USAGov config and database. It is not likely that this will impact functionality, but below is a description of what we expect to continue working.

  • Go to life event "Benefit finder: death of a loved one" edit page
  • Verify field ID is required
  • Verify field Page intro
  • Verify field Meta Description
  • Verify field Short Description
  • Verify field Search Title
  • Go to criteria "Deceased served in active military" edit page
  • Verify field ID is required
  • Verify check field has Child to show field Child Dependency Option
  • Verify uncheck field has Child to hide field Child Dependency Option
  • Go to benefit "COVID-19 funeral assistance" edit page
  • Verify no life event field
  • Go to life event form "Benefit finder: death of a loved one" edit page
  • Verify field life event form is required field in field relevant benefit
  • Navigate to admin/config/development/usagov_benefit_finder
  • Verify Automate JSON file generation checked

scottqueen-bixal and others added 30 commits June 27, 2024 12:34
…ales and implement functional programing with validating error codes, and links validation run
….com:GSA/px-benefit-finder into 1516-new-event-open-all-accordions
scottqueen-bixal and others added 6 commits July 9, 2024 10:37
…ithub.com:GSA/px-benefit-finder into 1525-clean-benefit-finder-configuration
…files under custom/module location before copy over new updates
…tion

1525 clean benefit finder configuration
…-if-used

1521 disable life event form delete if still used
@scottqueen-bixal scottqueen-bixal marked this pull request as ready for review July 10, 2024 14:06
@scottqueen-bixal scottqueen-bixal merged commit a88f4a5 into main Jul 10, 2024
12 checks passed
@gchi25
Copy link
Collaborator

gchi25 commented Jul 10, 2024

In MAIN site,
Tested custom module Improvements. All worked as expected.

Custom module Improvements

Cannot delete life event form if still used #1521
Clean benefit finder configuration #1525
Disable json file generation in BF multi-content action #1338

NOTE:
Cannot delete life event form if still used #1521
I did not remove life event form in relevant benefit.
I did not delete life event form.

@gchi25
Copy link
Collaborator

gchi25 commented Jul 10, 2024

In MAIN site,
Tested UI content Improvements. All worked as expected.

UI Content Improvements

Zero Benefits Translation Content #1453

Copy link
Collaborator

@gchi25 gchi25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. All worked as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants