-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.5.0.beta.1 (sprint 35) #1546
Conversation
…es for zero benefits view
…or zero benefits view
…otEligibleview state
…Accordion and its event value
…all interactions on results view
…new links prod links confir
…ales and implement functional programing with validating error codes, and links validation run
…fore we run tests
…g to, and include url with thrown errors
1453 content translations zero ben
1514 update result view value
1516 update benefit event values
….com:GSA/px-benefit-finder into 1516-new-event-open-all-accordions
1392 handle codes prod link test
…ithub.com:GSA/px-benefit-finder into 1525-clean-benefit-finder-configuration
…files under custom/module location before copy over new updates
…tion 1525 clean benefit finder configuration
…-if-used 1521 disable life event form delete if still used
1541 remove deprecated function
…ent, inclue view title
…vent, include values as string and number types
…om:GSA/px-benefit-finder into 1536-1537-1538-datalayer-updates
…ld as a side effect
1536 1537 1538 datalayer updates
In MAIN site, Custom module ImprovementsCannot delete life event form if still used #1521 NOTE: |
In MAIN site, Data Layer ImprovementsUpdate accordion open data layer event names #1516 |
In MAIN site, UI Content Improvements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. All worked as expected.
PR Summary
Data Layer Improvements
Update accordion open data layer event names #1516
Create data layer push event for open all/close all accordion button on results pages #1515
Update pageView Data Layer variable #1514
Create data layer event to track benefit link click #1467
Add data layer value to track benefit accordion open #1466
UI Content Improvements
Zero Benefits Translation Content #1453
Custom module Improvements
Cannot delete life event form if still used #1521
Clean benefit finder configuration #1525
Disable json file generation in BF multi-content action #1338
Detailed Testing steps
Data Layer Improvements
Update accordion open data layer event names #1516
/benefit-finder/death
bf_accordion_open
bf_accordion_open
Create data layer push event for open all/close all accordion button on results pages #1515
/benefit-finder/death
Open all +
bf_open_all_accordions
event firestrue
Close all +
bf_open_all_accordions
event firesfalse
expected:
Update pageView Data Layer variable #1514
/benefit-finder/death
bf_page_change
event object hasbfData.pageView
value of"bf-result-eligible-view"
See benefits you did not qualify for
buttonbf_page_change
event object hasbfData.pageView
value of"bf-result-not-eligible-view"
expected:
Create data layer event to track benefit link click #1467
/benefit-finder/death
YES
to all radio fields"event": "bf_benefit_link",
is in the dataLayer array that includes its title valueAdd data layer value to track benefit accordion open #1466
/benefit-finder/death
YES
to all radio fields"event": "bf_benefit_click",
is in the dataLayer array that includes its title value"event": "bf_benefit_click",
is in the dataLayer array"event": "bf_benefit_click",
is in the dataLayer array that includes its title valueNew UI Content
Zero Benefits Translation Content #1453
/benefit-finder/death
expected view
Custom module Improvements
Disable json file generation in BF multi-content action #1338
admin/content?combine=&type=bears_criteria&status=All&langcode=All
Cannot delete life event form if still used #1521
admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
Delete
Delete
confirmation buttonSave
Save
Now delete life event form "Benefit finder: death of a loved one" again
Clean benefit finder configuration #1525
This work removes benefit finder partial-configuration which has already been exported to USAGov config and database. It is not likely that this will impact functionality, but below is a description of what we expect to continue working.
admin/config/development/usagov_benefit_finder