Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1541 remove deprecated function #1543

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

gchi25
Copy link
Collaborator

@gchi25 gchi25 commented Jul 9, 2024

PR Summary

This work removes deprecated function and uses entity API to get node.

Related Github Issue

Detailed Testing steps

To test in local development site or dev site.

  • Pull changes locally
  • Copy usagov_benefit_finder modules to local development site custom module usagov_benefit_finder
    Runbash scripts/pipeline/mv-usagov_benefit_finder.sh
  • Make local development site up at http://localhost
  • Navigate to admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
  • Go to life event form "Benefit finder: death of a loved one" edit page
  • Changed Time Estimate from 5-10 minutes to 10-20 minutes
  • Save as published to generate both draft and published JSON files
  • Navigate to benefit finder tool draft mode benefit-finder/death?mode=draft
  • Verify estimated time 10-20 minutes
  • Navigate to benefit finder tool published mode benefit-finder/death
  • Verify estimated time 10-20 minutes

@gchi25 gchi25 self-assigned this Jul 9, 2024
@gchi25 gchi25 requested a review from scottqueen-bixal July 9, 2024 13:25
@scottqueen-bixal scottqueen-bixal merged commit 5b2dfe3 into dev Jul 9, 2024
7 checks passed
@scottqueen-bixal scottqueen-bixal deleted the 1541-remove-deprecated-function branch July 9, 2024 17:27
@scottqueen-bixal scottqueen-bixal added this to the v0.5.0.beta.1 milestone Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated function node_revision_load
2 participants