Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.6.1 (Sprint 39) #1754

Merged
merged 49 commits into from
Aug 30, 2024
Merged

Release v0.6.1 (Sprint 39) #1754

merged 49 commits into from
Aug 30, 2024

Conversation

scottqueen-bixal
Copy link
Collaborator

PR Summary

Related Github Issue

Design improvements

DESIGN | Update Typography across application #1445
Buttons are not full width when screen width mobile #1747
Include all benefits icon #1739

Application Improvements

Error message not working on date fieldsets with out required flag #1737

Detailed Testing steps

DESIGN | Update Typography across application #1445

  • navigate through /death

Expected view(s)
screencapture-localhost-benefit-finder-death-2024-08-27-10_10_14

screencapture-localhost-benefit-finder-death-2024-08-27-10_10_35

screencapture-localhost-benefit-finder-death-2024-08-27-10_11_06

Screenshot 2024-08-27 at 10 11 46 AM

screencapture-localhost-benefit-finder-death-2024-08-27-10_11_53

screencapture-localhost-benefit-finder-death-2024-08-27-10_12_13

screencapture-localhost-benefit-finder-death-2024-08-27-10_12_29

screencapture-localhost-benefit-finder-death-2024-08-27-10_12_59

Buttons are not full width when screen width mobile #1747

  • open inspector
  • set width to 478 px on responsive window mode
  • navigate app noting that these inconsistencies have been resolved

before:

Screenshot 2024-08-30 at 12 20 57 PM Screenshot 2024-08-30 at 12 20 08 PM Screenshot 2024-08-30 at 12 19 16 PM

expected:
Screenshot 2024-08-30 at 12 58 36 PM

Include all benefits icon #1739

expected:

Screenshot 2024-08-28 at 6 43 05 PM

Error message not working on date fieldsets with out required flag #1737

  • navigate to /death
  • CLICK continue without providing any values
  • ensure error alert is rendered
  • SELECT an option from a fieldset with <select /> input
  • ensure the error is cleared
  • SELECT the default option --Select-- from the now valid input
  • ensure the error is flagged and the DOM updates as expected

expected:

Screen.Recording.2024-08-30.at.10.08.22.AM.mov
  • navigate to /all_benefits
  • on the first step of the form, SELECT a month value from the date fieldset
  • CLICK continue
  • ensure that the error alert is rendered
  • SELECT the default option --Select-- from the now invalid input
  • ensure that the error alert is cleared
  • CLICK continue
  • ensure that you can proceed to the next step
  • CLICK back to return to the first step
  • SELECT a month value from the date fieldset
  • CLICK continue
  • ensure that the error alert is rendered
  • SELECT the default option --Select-- from the now invalid input
  • ensure that the error alert is cleared
  • enter a day value to the date fieldset
  • CLCIK continue
  • ensure that the error alert is rendered

expected:

Screen.Recording.2024-08-30.at.10.15.21.AM.mov

Xavier Metichecchia and others added 30 commits June 20, 2024 10:16
1575 update life event controller dependency injection
PXBF-remove-npm-step-deploy: Remove npm install cmd from linters step
XavierMetichecchia and others added 19 commits August 27, 2024 12:04
PXBF-1739-all-benefits-icon: include all-benefits icons
@scottqueen-bixal scottqueen-bixal marked this pull request as ready for review August 30, 2024 22:17
@scottqueen-bixal scottqueen-bixal merged commit f9da1aa into main Aug 30, 2024
15 checks passed
@scottqueen-bixal scottqueen-bixal changed the title v0.6.1 (Sprint 39) Release v0.6.1 (Sprint 39) Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants