Footer updates

[r-bartlett-gsa]

As a benefits tool user, in order to navigate between USAGov and benefits tool subsite without confusion, I would like the benefit tool subsite to resemble USAGov look and feel as close as possible.

Acceptance criteria:

• Update footer to match USAGov's beta site
• Update footer social media icons to match USAGov's beta site

Resources:

• Design review document (Current design review #553)
• Design prioritization spreadsheet

Definition of Done:

• Code complete
• Tests coverage is greater than team benchmark (90% goal)
• Security scans passed
• Acceptance Criteria is met and it works as expected
• Accessibility tested
• Cross browser tested
• Build process and deployment is automated and repeatable
• Load testing/performance testing
• Self Documentation whenever possible
• Feature toggles if appropriate
• Deployed to staging
• Usability testing
• PR approved / Peer reviewed
• A11y tested by Meghan
• PO approved (UX, usability, edge cases)

More details about each item can be find in BEARS P4 DoD google doc

QA checklist

[danny-englander]

This is dependent on #580 and #581.

[fpigeonjr]

I have completed my involvement with this GitHub issue and am stepping away from it.
Thank you for your understanding.

[nehemiah-abuga]

I have validated the footer navigation and ensured the link text and links match

[danny-englander]

@amycole501 Ready for you to test.

Steps

1. Go to: https://federalist-edd11e6f-8be2-4dc2-a85e-1782e0bcb08e.sites.pages.cloud.gov/preview/gsa/usagov-benefits-eligibility/multi-life-event-2023/death-of-a-loved-one/?
2. test the footer navigation for accessibility

[amycole501]

1. Keyboard interaction was fine (Chrome, desktop).
2. The footer header levels are set to H2. Can those be changed to H3? Since they aren't highly important content it doesn't make sense to have them be at the same heading level as the accordions and other sections. On the beta site the heading levels are H3 for "Government information" and other footer links.
3. Zooming to 200% display was fine.

[danny-englander]

@amycole501 I've made updates based on your feedback. Can you retest at:

https://federalist-edd11e6f-8be2-4dc2-a85e-1782e0bcb08e.sites.pages.cloud.gov/preview/gsa/usagov-benefits-eligibility/multi-life-event-2023/death-of-a-loved-one/

[amycole501]

When I use JAWS to skim for the different regions the search region shows up below the "main navigation" region.

Visually on the page it shows up above it. Can it move?

Also, I hear "navigation navigation" twice in both the header and footer. USA.gov has this set up as well and it's repetitive. Can you somehow remove one of the navigations so it's not repeating itself? See screen shot to understand what I'm talking about on both points.

[danny-englander]

Hi @amycole501 can you retest the navigations? The header should now announce as "Header primary navigation" and the footer should announce as "Footer navigation" As for the out of order items in the header, Ernie has said to pass on that one for now as we are putting most of our efforts into V2 now. Thanks!

https://federalist-edd11e6f-8be2-4dc2-a85e-1782e0bcb08e.sites.pages.cloud.gov/preview/gsa/usagov-benefits-eligibility/multi-life-event-2023/death-of-a-loved-one/

[amycole501]

Sounds great in JAWS ("Header primary navigation region" and "footer navigation region)

The footer specifically says "Content info region; footer navigation region". Not sure if it's supposed to have two names but it does now say "footer navigation region" which is great.

[danny-englander]

Ok I think we can close this as done!