Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Header updates #580

Closed
8 of 17 tasks
r-bartlett-gsa opened this issue Dec 16, 2022 · 6 comments · Fixed by #661
Closed
8 of 17 tasks

Header updates #580

r-bartlett-gsa opened this issue Dec 16, 2022 · 6 comments · Fixed by #661
Assignees

Comments

@r-bartlett-gsa
Copy link
Contributor

r-bartlett-gsa commented Dec 16, 2022

As a benefits tool user, in order to navigate between USAGov and benefits tool subsite without confusion, I would like the benefit tool subsite to resemble USAGov look and feel as close as possible.

Acceptance criteria:

  • Move the language toggle above the search bar
  • Update phone number in the header styling and placement to match USAGov's beta site

Resources:

Definition of Done:

  • Code complete
  • Tests coverage is greater than team benchmark (90% goal)
  • Security scans passed
  • Acceptance Criteria is met and it works as expected
  • Accessibility tested
  • Cross browser tested
  • Build process and deployment is automated and repeatable
  • Load testing/performance testing
  • Self Documentation whenever possible
  • Feature toggles if appropriate
  • Deployed to staging
  • Usability testing
  • PR approved / Peer reviewed
  • A11y tested by Meghan
  • PO approved (UX, usability, edge cases)

More details about each item can be find in BEARS P4 DoD google doc

QA checklist

@fpigeonjr
Copy link
Contributor

fpigeonjr commented Feb 6, 2023

This is part of the work on PR #616.

@danny-englander danny-englander mentioned this issue Feb 7, 2023
17 tasks
@danny-englander
Copy link
Contributor

This is dependent on #582 and #581.

@danny-englander danny-englander mentioned this issue Feb 7, 2023
16 tasks
@fpigeonjr
Copy link
Contributor

I have completed my involvement with this GitHub issue and am stepping away from it.
Thank you for your understanding.

@danny-englander
Copy link
Contributor

@nehemiah-abuga This is ready for testing. For this ticket, we are testing the header for widescreens for visual similarity to https://beta.usa.gov/

  1. Pull this branch locally: multi-life-event-2023
  2. Test the header as compared to https://beta.usa.gov/ for desktop
  3. switch languages to Spanish and repeat the test.

Note, there may be some minor differences. We will test for mobile once #689 is complete, at the moment that ticket is blocked.

2023-03-28_15-12-41

2023-03-28_15-16-33

@nehemiah-abuga
Copy link
Contributor

I have verified this change and the headers are similar.

@danny-englander
Copy link
Contributor

Noting that Amy is testing the header over in #581 (comment) so I will mark this one as done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants