Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

[bug] footer notice in mutl-life event version not updating to set language when language is switched #630

Closed
danny-englander opened this issue Jan 30, 2023 · 3 comments · Fixed by #661
Assignees
Labels
bug Something isn't working task

Comments

@danny-englander
Copy link
Contributor

What's expected

After clicking the language button, the footer notice should immediately be translated without a hard page refresh.

What happened

In the mutl-life event version of the app, the footer notice that says:

Important Notice:
We provide an estimated list of federal benefits that might be appropriate for you (the person applying for benefits), but the only way to find out true eligibility is to apply.
State, city, or employer may offer other benefits. Be sure to check these out for a full picture of the help available.

does not translate after clicking the top language button, for example "Español"

How to replicate

  1. Use the app in multi-life event mode, for example https://federalist-edd11e6f-8be2-4dc2-a85e-1782e0bcb08e.sites.pages.cloud.gov/preview/gsa/usagov-benefits-eligibility/new-life-experiences_12-5-22/death-of-a-loved-one/?
  2. Click on the Español button to change languages
  3. scroll to the bottom of the page where it says "Important Notice:"
  4. note that the title and text beneath is still in English
  5. Now do a hard refresh of the page
  6. note that the title and text beneath is now in Spanish
@danny-englander danny-englander added the bug Something isn't working label Jan 30, 2023
@danny-englander danny-englander changed the title [bug] footer notice in mutl-life event version not updating when language is switched [bug] footer notice in mutl-life event version not updating to set language when language is switched Jan 30, 2023
danny-englander added a commit that referenced this issue Feb 6, 2023
@danny-englander
Copy link
Contributor Author

This will be fixed as part of #582

@danny-englander
Copy link
Contributor Author

danny-englander commented Mar 10, 2023

@nehemiah-abuga This is ready for testing

  • Pull multi-life-event-2023 to your local
  • run npm i
  • Run npm run dev
  • Go to http://localhost:3000
  • view the text block at the bottom of the page usa-summary-box footer-summary-box
Important Notice:
We provide an estimated list of federal benefits that might be appropriate for you (the person applying for benefits), but the only way to find out true eligibility is to apply.
State, city, or employer may offer other benefits. Be sure to check these out for a full picture of the help available.
  • Note that the text is in English
  • Now switch language to Spanish
  • go scroll down to the same notice. It should now be in Spanish without a manual page reload
  • Now switch language back to English
  • The notice at the bottom should once again be in English without a manual page reload

@nehemiah-abuga
Copy link
Contributor

I have verified the language is updating correctly when switching

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants