Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no private key available for account #597

Closed
tomholub opened this issue Jul 1, 2019 · 6 comments
Closed

no private key available for account #597

tomholub opened this issue Jul 1, 2019 · 6 comments
Assignees
@DenBond7
Labels
core
Milestone
1.5.6

Comments

@tomholub
Copy link
Collaborator

tomholub commented Jul 1, 2019 •
edited
Loading

We should offer solutions to this
-> import key (or load from backups)
-> add email to existing key (can edit key using pgpainless to add user)
-> create a new key for email

Keeps bothering me, and our users too

Screenshot_20190629-215402
@tomholub tomholub added this to the soon milestone Jul 1, 2019
This was referenced Sep 4, 2019
Closed
Open
@tomholub
Copy link
Collaborator Author

tomholub commented Sep 5, 2019

part of #714

@tomholub tomholub added the core label Mar 20, 2021
@DenBond7 DenBond7 modified the milestones: soon, 1.5.4 Feb 14, 2024
DenBond7 added a commit that referenced this issue Mar 19, 2024
@DenBond7
Added ActionsDialogFragmen.| #597
f4b3703
@DenBond7 DenBond7 modified the milestones: 1.5.5, 1.5.6 Mar 26, 2024
@DenBond7 DenBond7 mentioned this issue Mar 26, 2024
Merged
4 tasks
DenBond7 added a commit that referenced this issue Mar 27, 2024
@DenBond7
Added ComposeScreenNoKeyAvailableFlowTest.| #597
2bae042
DenBond7 added a commit that referenced this issue Mar 28, 2024
@DenBond7
fixed "no private key available" issue. Part 1. import key (or load f…
b30cdf1 
…rom backups) (#2660)

* wip

* Added ActionsDialogFragmen.| #597

* wip

* wip

* wip

* wip

* Added ComposeScreenNoKeyAvailableFlowTest.| #597
@DenBond7
Copy link
Collaborator

@sosnovsky As I understand we should not allow to add email to existing key and create a new key for email for enterprise users where keyManagerUrl != null. Please correct me if needed.

@DenBond7 DenBond7 changed the title no public key available for account no private key available for account Mar 28, 2024
@DenBond7
Copy link
Collaborator

How to reproduce:

  1. Setup the app for example for [email protected]
  2. Go to Settings -> Keys
  3. Import a new key for example for [email protected]
  4. Delete the key for [email protected]
  5. Go to the compose screen and try to send an encrypted message

@DenBond7
Copy link
Collaborator

Need to add that users who have an alias for their Gmail account can see this issue if a private key doesn't have userId == alias and a user is trying to use the alias to send a message.

@sosnovsky
Copy link
Collaborator

@sosnovsky As I understand we should not allow to add email to existing key and create a new key for email for enterprise users where keyManagerUrl != null. Please correct me if needed.

I think it should be allowed in this case, but updated key needs to be synchronized to key manager.

Mentioned operations should be disabled when there is NO_PRV_CREATE flag in client configuration (in this case app should show alert with Please contact support at ... message)

DenBond7 added a commit that referenced this issue Apr 2, 2024
@DenBond7
Added ChoosePrivateKeyDialogFragment.| #597
f8dcaec
@DenBond7 DenBond7 mentioned this issue Apr 2, 2024
Merged
4 tasks
DenBond7 added a commit that referenced this issue Apr 2, 2024
@DenBond7
Added AddNewUserIdToPrivateKeyDialogFragment.| #597
352fe9e
DenBond7 added a commit that referenced this issue Apr 3, 2024
@DenBond7
'add email to existing key'. Handled a case when a private key has a …
c4ab639 
…passphrase in RAM.| #597
DenBond7 added a commit that referenced this issue Apr 3, 2024
@DenBond7
'add email to existing key'. Added updating contacts after editing a …
97b294e 
…private key.| #597
DenBond7 added a commit that referenced this issue Apr 4, 2024
@DenBond7
Fixed option "no private key available|add email to existing key" if …
a9cb84c 
…only a single key exists.| #597
DenBond7 added a commit that referenced this issue Apr 4, 2024
@DenBond7
Added ComposeScreenNoKeyAvailableFlowTest.testAddEmailToExistingSingl…
e34f85c 
…eKeyPassphraseInDatabase().| #597
DenBond7 added a commit that referenced this issue Apr 4, 2024
@DenBond7
Added ComposeScreenNoKeyAvailableMultipleKeysWithPassphraseInDatabase…
52b1baf 
…FlowTest.| #597
DenBond7 added a commit that referenced this issue Apr 4, 2024
@DenBond7
Added ComposeScreenNoKeyAvailableMultipleKeysWithPassphraseInRamFlowT…
3a6b813 
…est.| #597
DenBond7 added a commit that referenced this issue Apr 4, 2024
@DenBond7
Added ComposeScreenNoKeyAvailableSingleKeyWithPassphraseInRamFlowTest.|
7d45767 
#597
DenBond7 added a commit that referenced this issue Apr 5, 2024
@DenBond7
fixed "no private key available" issue. Part 2. add email to existing…
da407eb 
… key (#2669)

* Added ChoosePrivateKeyDialogFragment.| #597

* Added AddNewUserIdToPrivateKeyDialogFragment.| #597

* 'add email to existing key'. Handled a case when a private key has a passphrase in RAM.| #597

* 'add email to existing key'. Added updating contacts after editing a private key.| #597

* wip

* wip

* Fixed option "no private key available|add email to existing key" if only a single key exists.| #597

* Added ComposeScreenNoKeyAvailableFlowTest.testAddEmailToExistingSingleKeyPassphraseInDatabase().| #597

* wip

* wip

* Added ComposeScreenNoKeyAvailableMultipleKeysWithPassphraseInDatabaseFlowTest.| #597

* Added ComposeScreenNoKeyAvailableMultipleKeysWithPassphraseInRamFlowTest.| #597

* Added ComposeScreenNoKeyAvailableSingleKeyWithPassphraseInRamFlowTest.| #597

* Refactored code
DenBond7 added a commit that referenced this issue Apr 8, 2024
@DenBond7
Handled the case "no private key available for account(create a new k…
391ab6d 
…ey for email)".| #597
@DenBond7 DenBond7 mentioned this issue Apr 8, 2024
Merged
4 tasks
DenBond7 added a commit that referenced this issue Apr 9, 2024
@DenBond7
Fixed navigation.| #597
4050324
DenBond7 added a commit that referenced this issue Apr 9, 2024
@DenBond7
Added ComposeScreenNoKeyAvailableCreateNewKeyFlowTest.| #597
9513d8e
sosnovsky pushed a commit that referenced this issue Apr 9, 2024
@DenBond7
Handled the case "no private key available for account(create a new k…
bc8015f 
…ey for email) (#2675)

* Handled the case "no private key available for account(create a new key for email)".| #597

* Fixed navigation.| #597

* Added ComposeScreenNoKeyAvailableCreateNewKeyFlowTest.| #597

* Refactored code

* Refactored code

* wip
@DenBond7
Copy link
Collaborator

Fixed by #2660 #2669 #2675

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DenBond7 DenBond7

Labels
core
Projects
None yet
Milestone
1.5.6
Development

No branches or pull requests
3 participants
@sosnovsky @DenBond7 @tomholub