Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed "no private key available" issue. Part 2. add email to existing key #2669

Merged
merged 15 commits into from
Apr 5, 2024

Conversation

DenBond7
Copy link
Collaborator

@DenBond7 DenBond7 commented Apr 2, 2024

This PR added the second option add email to existing key

issue #597

Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities

@DenBond7
Copy link
Collaborator Author

DenBond7 commented Apr 3, 2024

For this scenario need to add the following test

  • 1. Updating a key with a locally saved passphrase
  • 2. Updating a key with a passphrase in RAM
  • 3. test a single key

@DenBond7
Copy link
Collaborator Author

DenBond7 commented Apr 4, 2024

How to test(only one key exists):

  1. Setup the app for example for [email protected]
  2. Go to Settings -> Keys
  3. Import a new key for example for [email protected]
  4. Delete the key for [email protected]
  5. Go to the compose screen and try to send an encrypted message

How to test(multiple keys exist):

  1. Setup the app for example for [email protected]
  2. Go to Settings -> Keys
  3. Import a new key for example for [email protected]
  4. Import a new key for example for [email protected]
  5. Delete the key for [email protected]
  6. Go to the compose screen and try to send an encrypted message

Also, the behavior will be different for case passphraseType = KeyEntity.PassphraseType.RAM when a private key has no passphrase in RAM.

@DenBond7 DenBond7 marked this pull request as ready for review April 4, 2024 08:37
@DenBond7 DenBond7 requested a review from sosnovsky as a code owner April 4, 2024 08:37
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 👍

@DenBond7 DenBond7 merged commit da407eb into master Apr 5, 2024
8 checks passed
@DenBond7 DenBond7 deleted the issue_597_add_user_id_to_exsisting_private_key branch April 5, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants