Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handled the case "no private key available for account(create a new key for email) #2675

Merged
merged 6 commits into from
Apr 9, 2024
Merged

Handled the case "no private key available for account(create a new key for email) #2675

merged 6 commits into from
Apr 9, 2024

Conversation

DenBond7
Copy link
Collaborator

@DenBond7 DenBond7 commented Apr 8, 2024 •
edited by sosnovsky
Loading

This PR Handled the case "no private key available for account(create a new key for email)

issue #597

Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities

@DenBond7 DenBond7 marked this pull request as ready for review April 9, 2024 11:19
@DenBond7 DenBond7 requested a review from sosnovsky as a code owner April 9, 2024 11:19
@DenBond7
Copy link
Collaborator Author

DenBond7 commented Apr 9, 2024

How to test:

  1. Setup the app for example for [email protected]
  2. Go to Settings -> Keys
  3. Import a new key for example for [email protected]
  4. Delete the key for [email protected]
  5. Go to the compose screen and try to send an encrypted message

sosnovsky
sosnovsky approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@sosnovsky sosnovsky merged commit bc8015f into master Apr 9, 2024
8 checks passed
@sosnovsky sosnovsky deleted the issue_597_no_private_key_available_for_account branch April 9, 2024 18:11
@DenBond7 DenBond7 mentioned this pull request Apr 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosnovsky sosnovsky sosnovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DenBond7 @sosnovsky