Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed "no private key available" issue. Part 1. import key (or load from backups) #2660

Merged
merged 9 commits into from
Mar 28, 2024

Conversation

DenBond7
Copy link
Collaborator

@DenBond7 DenBond7 commented Mar 26, 2024

This PR fixed "no public key available" issue

issue #597


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities

@DenBond7 DenBond7 changed the title fixed "no public key available" issue fixed "no public key available" issue. Part 1. import key (or load from backups) Mar 27, 2024
@DenBond7 DenBond7 marked this pull request as ready for review March 27, 2024 19:15
@DenBond7 DenBond7 requested a review from sosnovsky as a code owner March 27, 2024 19:15
@DenBond7
Copy link
Collaborator Author

How to test:

  1. Setup the app for example for [email protected]
  2. Go to Settings -> Keys
  3. Import a new key for example for [email protected]
  4. Delete the key for [email protected]
  5. Go to the compose screen and try to send an encrypted message

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well now 👍

But probably PR name should "no private key available" issue (not public key)

@DenBond7 DenBond7 changed the title fixed "no public key available" issue. Part 1. import key (or load from backups) fixed "no private key available" issue. Part 1. import key (or load from backups) Mar 28, 2024
@DenBond7 DenBond7 merged commit b30cdf1 into master Mar 28, 2024
8 checks passed
@DenBond7 DenBond7 deleted the issue_597_fix_no_public_key_available branch March 28, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants