Add support for GitHub recipient #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't #43 supercede this by being more generic? |
Yes, that's true. That PR likely needs support for "github:username" syntax, otherwise it supercedes. But this PR can be closed if that's going to be used! |
giuscri
reviewed
Jan 3, 2020
There was a problem hiding this comment.
I think it's better if
- parsing a JSON is avoided, as
https://github.com/user.keysgives already the result needed - this PR builds on top of Get recipient keys from https:// and file:// URLs #43, making
github:useran alias tohttps://github.com/user.keys
FiloSottile
added a commit
that referenced
this pull request
Jan 2, 2021
FiloSottile
added a commit
that referenced
this pull request
Jan 2, 2021
FiloSottile
added a commit
that referenced
this pull request
Jan 3, 2021
|
Hi! Thank you for contributing! I took a different path in #173, but it was useful to look at open PRs for the users' expectations. Let me know if that implementation works for you! I wrote up an explanation of why I ended up implementing recipient files and not HTTPS sources on the mailing list, and I appreciate feedback! https://groups.google.com/g/age-dev/c/StmWsOyb-H8/m/a44rSBIWCAAJ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to fetch user public keys directly from Github API. (edit: seems to be duplicate of #43)