Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get recipient keys from https:// and file:// URLs #43

Closed
wants to merge 1 commit into from

Conversation

paulc
Copy link

@paulc paulc commented Dec 28, 2019

This patch includes support for https:// and file:// URLs as recipient arguments. The URL is fetched and each line is added as a recipient.

e.g.

-r https://github.com/<user>.keys       (Use GitHub keys)
-r file:///home/<user>/.ssh/<key>.pub   (Use local SSH key)

This is mostly useful to allow recipient keys to be specified directly from a GitHub URL (or other service which provides an equivalent)

arguments. The URL is fetched and each line is added as a recipient.

e.g.

    -r https://github.com/<user>.keys       (Use GitHub keys)
    -r file:///home/<user>/.ssh/<key>.pub   (Use local SSH key)

This is mostly useful to allow recipient keys to be specified directly
from a GitHub URL (or other service which provides an equivalent)
@mohammed90
Copy link

Awesome! Should resolve #34 😃

@geek-at
Copy link

geek-at commented Jan 9, 2020

Any ETA on a merge?

@Fastidious
Copy link

I think this is a very useful PR. Any reasons why it should not be merged, @FiloSottile?

@geek-at
Copy link

geek-at commented Jan 21, 2020

seems like the project is dead. Development wise

@cyb3rz3us
Copy link

cyb3rz3us commented Jan 21, 2020

Not dead...just not a lot to really do. People are always free to pull and develop as they wish...

@Fastidious
Copy link

Fastidious commented Jan 21, 2020

@cyb3rz3us something like this is mentioned on age's design document. From it:

$ echo "_o/" | age -o hello.age -r https://github.com/FiloSottile.keys
$ echo "_o/" | age -r https://filippo.io/.well-known/age.keys

@cyb3rz3us
Copy link

cyb3rz3us commented Jan 21, 2020

I wasn't arguing for or against the feature (but I do agree it is a good thing) but rather that the project is dead...it's not dead...just not on fire. And if folks want to see stuff happen quicker, then pull and fork...

@Fastidious
Copy link

@cyb3rz3us I disregarded the "project is dead" comment altogether. I was just pointing out this PR is something that is/was wanted originally.

@cyb3rz3us
Copy link

Agreed...

FiloSottile added a commit that referenced this pull request Jan 2, 2021
Fixes #84
Closes #165
Closes #158
Closes #115
Closes #64
Closes #43
Closes #20
FiloSottile added a commit that referenced this pull request Jan 2, 2021
Fixes #84
Fixes #66
Closes #165
Closes #158
Closes #115
Closes #64
Closes #43
Closes #20
FiloSottile added a commit that referenced this pull request Jan 3, 2021
Fixes #84
Fixes #66
Closes #165
Closes #158
Closes #115
Closes #64
Closes #43
Closes #20
@FiloSottile
Copy link
Owner

Hi! Thank you for contributing! I took a different path in #173, but it was useful to look at open PRs for the users' expectations. Let me know if that implementation works for you!

I wrote up an explanation of why I ended up implementing recipient files and not HTTPS sources on the mailing list, and I appreciate feedback! https://groups.google.com/g/age-dev/c/StmWsOyb-H8/m/a44rSBIWCAAJ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants