Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipient file support #165

Closed
wants to merge 2 commits into from
Closed

Conversation

sylr
Copy link

@sylr sylr commented Dec 16, 2020

No description provided.

@codesoap
Copy link
Contributor

codesoap commented Jan 1, 2021

I'm not a fan of this pull request. The new behaviour seems unintuitive to me and is achievable with the features that age provide already. age is supposed to be a UNIX-style tool, so I think combining it with xargs would be a simpler way to support recipient files (you can easily put this into a script if you do it often):

$ cat recipients
age1cted2nsw07mzjue9uwlxh020zhvf42sh5lywzunqnggepver8yjq0t0jtp
age1x7xk50anca87rcvuw6u3k88dvkfkwlf58dwyz3t5rum94vw2l5hq6k6d0s
$ awk '{print "-r", $0}' recipients | xargs -J % age % -o data.age data

I highly value orthogonality in the features of tools and would hate to see such unneeded feature creep in age.

@codesoap codesoap mentioned this pull request Jan 1, 2021
@sylr
Copy link
Author

sylr commented Jan 1, 2021

How can

age -r recipients -o data.age data

be less intuitive than

awk '{print "-r", $0}' recipients | xargs -J % age % -o data.age data

?

@codesoap
Copy link
Contributor

codesoap commented Jan 1, 2021

I find it unintuitive that -r should take a string, which could be either interpreted as a key or a filename. I find this ambiguity confusing. As I suggested already, you could put the xargs stuff into a script, if you find yourself using something like this frequently.

FiloSottile added a commit that referenced this pull request Jan 2, 2021
Fixes #84
Closes #165
Closes #158
Closes #115
Closes #64
Closes #43
Closes #20
FiloSottile added a commit that referenced this pull request Jan 2, 2021
Fixes #84
Fixes #66
Closes #165
Closes #158
Closes #115
Closes #64
Closes #43
Closes #20
FiloSottile added a commit that referenced this pull request Jan 3, 2021
Fixes #84
Fixes #66
Closes #165
Closes #158
Closes #115
Closes #64
Closes #43
Closes #20
@FiloSottile
Copy link
Owner

Hi! Thank you for contributing! I took a different path in #173, but it was useful to look at open PRs for the users' expectations. Let me know if that implementation works for you!

I wrote up an explanation of why I ended up implementing recipient files and not HTTPS sources on the mailing list, and I appreciate feedback! https://groups.google.com/g/age-dev/c/StmWsOyb-H8/m/a44rSBIWCAAJ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants