-
-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support remote URLs and "github://", "file://" schemes to fetch recipient public keys #115
Conversation
arguments. The URL is fetched and each line is added as a recipient. e.g. -r https://github.com/<user>.keys (Use GitHub keys) -r file:///home/<user>/.ssh/<key>.pub (Use local SSH key) This is mostly useful to allow recipient keys to be specified directly from a GitHub URL (or other service which provides an equivalent)
9248bfb
to
181402a
Compare
worth noting that this introduces networking and uses default someone could later add proxy support via environmental variable or flag |
A problem here is that the URI prefix will surely frustrate tab-completion. That is, I can type It's a minor usability issue, certainly, but it's enough of an issue that it makes me feel as if I'm missing something. |
https://github.com/hashicorp/go-getter might be relevent to this. |
Hi! Thank you for contributing! I took a different path in #173, but it was useful to look at open PRs for the users' expectations. Let me know if that implementation works for you! I wrote up an explanation of why I ended up implementing recipient files and not HTTPS sources on the mailing list, and I appreciate feedback! https://groups.google.com/g/age-dev/c/StmWsOyb-H8/m/a44rSBIWCAAJ |
This PR supersedes #43 and #64, adding support for
github://
,file://
and URL schemes (https://
) for the-r
(RECIPIENT) flagCloses #84
Example usage:
Thank you @paulc for laying the framework for the
github://
scheme