i#6020 interval analysis: Fix interval counts regex #6116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that we do not track unique PCs in combined interval snapshots. Also fixes expected regex of basic counts interval output so that only digits and leading white-spaces are accepted at the beginning of each line. Issue: #6020
clients/drcachesim/tests/offline-interval-count-output.templatex
Outdated
Show resolved
Hide resolved
derekbruening
approved these changes
Jun 6, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
vs2019-32 failure is #6081. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that we do not track unique PCs in the combined interval
snapshots. Since the shard-local snapshots themselves do not track
unique pcs, the combined snapshot also wouldn't have anything in
the unique pc set. But we need to explicitly disable unique pcs
tracking so that we skip printing that field. This was missing in the
original PR #6097.
Also fixes expected regex of basic counts interval output so that only
digits and leading white-spaces are accepted at the beginning of each
line. Otherwise we aren't able to detect that the unique pc addrs line
in the counters output is still present.
Also fixes a regression due to #6113 which causes a regex match
failure in case only a single interval is output for the whole trace.
Issue: #6020, #6112