Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASSERT callback.c:1477 in tool.drcacheoff.gencode test on win32 #6081

Open
derekbruening opened this issue May 24, 2023 · 4 comments
Open

ASSERT callback.c:1477 in tool.drcacheoff.gencode test on win32 #6081

derekbruening opened this issue May 24, 2023 · 4 comments

Comments

@derekbruening
Copy link
Contributor

This happened 3x in a row (else it would have passed) -- yet I don't think we've ever seen this before. This test passed in other runs of the same code so it is non-deterministic -- maybe in some environment it becomes repeatable.

https://github.com/DynamoRIO/dynamorio/actions/runs/5073007903/jobs/9111470544

275:  pre-DR start
275: 
275:   <Application
275:   D:\a\dynamorio\dynamorio\build_debug-internal-32\suite\tests\bin\tool.drcacheoff.gencode.exe
275:   (7024).  Internal Error: DynamoRIO debug check failure:
275:   D:\a\dynamorio\dynamorio\core\win32\callback.c:1477 false
275: 
275:   (Error occurred @77 frags in tid 6752)
@derekbruening
Copy link
Contributor Author

This happened on the windows-timestamps test too on win64:
https://github.com/DynamoRIO/dynamorio/actions/runs/6855254589/job/18639921072?pr=6445

264/305 Test #267: code_api|tool.drcacheoff.windows-timestamps ......................***Failed    0.17 sec
Running cmd |D:/a/dynamorio/dynamorio/build_debug-internal-64/clients/bin64/tool.drcacheoff.windows-timestamps.exe|
CMake Error at D:/a/dynamorio/dynamorio/suite/tests/runmulti.cmake:111 (message):
  *** cmd failed (-1): <Application
  D:\a\dynamorio\dynamorio\build_debug-internal-64\clients\bin64\tool.drcacheoff.windows-timestamps.exe
  (1656).  Internal Error: DynamoRIO debug check failure:
  D:\a\dynamorio\dynamorio\core\win32\callback.c:1477 false

  (Error occurred @55 frags in tid 1768)

@derekbruening
Copy link
Contributor Author

This is now at callback.c:1480 FTR. Happened again in windows-timestamps at https://github.com/DynamoRIO/dynamorio/actions/runs/7123468151/job/19396119425?pr=6494

@edeiana
Copy link
Contributor

edeiana commented Mar 12, 2024

Hitting the same callback.c:1480 debug check failure (PR #6698).
(Note: it only happened once, it usually passes).

2024-03-12T05:50:34.2666884Z 268/310 Test #271: code_api|tool.drcacheoff.windows-timestamps ......................***Failed    0.18 sec
2024-03-12T05:50:34.2668775Z Running cmd |D:/a/dynamorio/dynamorio/build_debug-internal-64/clients/bin64/tool.drcacheoff.windows-timestamps.exe|
2024-03-12T05:50:34.2670610Z CMake Error at D:/a/dynamorio/dynamorio/suite/tests/runmulti.cmake:114 (message):
2024-03-12T05:50:34.2671691Z   *** cmd failed (-1): <Application
2024-03-12T05:50:34.2672944Z   D:\a\dynamorio\dynamorio\build_debug-internal-64\clients\bin64\tool.drcacheoff.windows-timestamps.exe
2024-03-12T05:50:34.2674322Z   (4156).  Internal Error: DynamoRIO debug check failure:
2024-03-12T05:50:34.2675291Z   D:\a\dynamorio\dynamorio\core\win32\callback.c:1480 false
2024-03-12T05:50:34.2675977Z 
2024-03-12T05:50:34.2676322Z   (Error occurred @55 frags in tid 5312)
2024-03-12T05:50:34.2676870Z 
2024-03-12T05:50:34.2677182Z   version 10.0.19794, custom build

derekbruening added a commit that referenced this issue Mar 27, 2024
To get the post-merge suite green, we ignore failures in the
code_api|tool.drcacheoff.windows-timestamps test on win32.  That is a
lower priority platform and there are just not enough maintainers for
that platform to chase down these issues at this time.

Issue: #6081
@derekbruening
Copy link
Contributor Author

The windows-timestamps is relatively frequent, appearing in maybe 1 out of 5 post-merge suites. I'm going to mark it ignore on win32 to get that greener.

derekbruening added a commit that referenced this issue Mar 27, 2024
…#6737)

To get the post-merge suite green, we ignore failures in the
code_api|tool.drcacheoff.windows-timestamps test on win32. That is a
lower priority platform and there are just not enough maintainers for
that platform to chase down these issues at this time.

Issue: #6081
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants