i#6112: Require a full output match in runmulti #6113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brackets the expected outpout with ^$ to require a complete match for tests using runmulti.cmake. This matches what we do for single-command tests for their PASS_REGULAR_EXPRESSION property. Fixes #6112
Clear old command output in runmulti to avoid bogus output seen in delay-func test.
abhinav92003
approved these changes
Jun 5, 2023
This was referenced Jun 6, 2023
abhinav92003
added a commit
that referenced
this pull request
Jun 6, 2023
Ensures that we do not track unique PCs in the combined interval snapshots. Since the shard-local snapshots themselves do not track unique pcs, the combined snapshot also wouldn't have anything in the unique pc set. But we need to explicitly disable unique pcs tracking so that we skip printing that field. This was missing in the original PR #6097. Also fixes expected regex of basic counts interval output so that only digits and leading white-spaces are accepted at the beginning of each line. Otherwise we aren't able to detect that the unique pc addrs line in the counters output is still present. Also fixes a regression due to #6113 which causes a regex match failure in case only a single interval is output for the whole trace. Issue: #6020, #6112
derekbruening
added a commit
that referenced
this pull request
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brackets the expected outpout with ^$ to require a complete match for tests using runmulti.cmake. This matches what we do for single-command tests for their PASS_REGULAR_EXPRESSION property.
Adjusts the expected output for 6 tests to meet the new check.
Clears the old command output in runmulti to avoid bogus output seen in the delay-func test where the post-command's echo has ho glob match so it was appending another "Hello, world!".
Fixes #6112