Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#6020 interval analysis: Fix interval counts regex #6116

Merged
merged 4 commits into from
Jun 6, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 49 additions & 49 deletions clients/drcachesim/tests/offline-interval-count-output.templatex
Original file line number Diff line number Diff line change
@@ -1,61 +1,61 @@
Hello, world!
Basic counts tool results:
Total counts:
.* total \(fetched\) instructions
.* total unique \(fetched\) instructions
.* total non-fetched instructions
.* total prefetches
.* total data loads
.* total data stores
.* total icache flushes
.* total dcache flushes
[ 0-9]* total \(fetched\) instructions
[ 0-9]* total unique \(fetched\) instructions
[ 0-9]* total non-fetched instructions
[ 0-9]* total prefetches
[ 0-9]* total data loads
[ 0-9]* total data stores
[ 0-9]* total icache flushes
[ 0-9]* total dcache flushes
1 total threads
.* total scheduling markers
.* total transfer markers
.* total function id markers
.* total function return address markers
.* total function argument markers
.* total function return value markers
[ 0-9]* total scheduling markers
[ 0-9]* total transfer markers
[ 0-9]* total function id markers
[ 0-9]* total function return address markers
[ 0-9]* total function argument markers
[ 0-9]* total function return value markers
0 total physical address \+ virtual address marker pairs
0 total physical address unavailable markers
.* total other markers
.* total encodings
Thread .* counts:
.* \(fetched\) instructions
.* unique \(fetched\) instructions
.* non-fetched instructions
.* prefetches
.* data loads
.* data stores
.* icache flushes
.* dcache flushes
.* scheduling markers
.* transfer markers
.* function id markers
.* function return address markers
.* function argument markers
.* function return value markers
[ 0-9]* total other markers
[ 0-9]* total encodings
Thread [0-9]* counts:
[ 0-9]* \(fetched\) instructions
[ 0-9]* unique \(fetched\) instructions
[ 0-9]* non-fetched instructions
[ 0-9]* prefetches
[ 0-9]* data loads
[ 0-9]* data stores
[ 0-9]* icache flushes
[ 0-9]* dcache flushes
[ 0-9]* scheduling markers
[ 0-9]* transfer markers
[ 0-9]* function id markers
[ 0-9]* function return address markers
[ 0-9]* function argument markers
[ 0-9]* function return value markers
0 physical address \+ virtual address marker pairs
0 physical address unavailable markers
.* other markers
.* encodings
[ 0-9]* other markers
[ 0-9]* encodings
Counts per trace interval for whole trace:
Interval #1 ending at timestamp.*
.* interval delta \(fetched\) instructions
.* interval delta non-fetched instructions
.* interval delta prefetches
.* interval delta data loads
.* interval delta data stores
.* interval delta icache flushes
.* interval delta dcache flushes
.* interval delta scheduling markers
.* interval delta transfer markers
.* interval delta function id markers
.* interval delta function return address markers
.* interval delta function argument markers
.* interval delta function return value markers
Interval #1 ending at timestamp [0-9]*:
[ 0-9]* interval delta \(fetched\) instructions
[ 0-9]* interval delta non-fetched instructions
[ 0-9]* interval delta prefetches
[ 0-9]* interval delta data loads
[ 0-9]* interval delta data stores
[ 0-9]* interval delta icache flushes
[ 0-9]* interval delta dcache flushes
[ 0-9]* interval delta scheduling markers
[ 0-9]* interval delta transfer markers
[ 0-9]* interval delta function id markers
[ 0-9]* interval delta function return address markers
[ 0-9]* interval delta function argument markers
[ 0-9]* interval delta function return value markers
0 interval delta physical address \+ virtual address marker pairs
0 interval delta physical address unavailable markers
.* interval delta other markers
.* interval delta encodings.*
[ 0-9]* interval delta other markers
[ 0-9]* interval delta encodings
.*
abhinav92003 marked this conversation as resolved.
Show resolved Hide resolved
7 changes: 7 additions & 0 deletions clients/drcachesim/tools/basic_counts.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,13 @@ basic_counts_t::combine_interval_snapshots(
uint64_t interval_end_timestamp)
{
count_snapshot_t *result = new count_snapshot_t;
// The snapshots in latest_shard_snapshots do not track unique_pc_addrs, so
// the combined result->counters also would not contain any element in the
// unique_pc_addrs set. But we still need to explicitly disable
// unique_pc_addrs tracking in result->counters using the following function
// call. This is so that printing of unique_pc_addrs count is skipped as
// intended during print_interval_results.
result->counters.stop_tracking_unique_pc_addrs();
for (const auto snapshot : latest_shard_snapshots) {
if (snapshot == nullptr)
continue;
Expand Down