Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASSERT signal marker invariants in histogram.offline test on AArch64 #3980

Open
derekbruening opened this issue Dec 11, 2019 · 3 comments
Open

Comments

@derekbruening
Copy link
Contributor

Xref #2899 where this test hangs.

This is a new assert on signal marker invariants and it just fired:

http://139.178.83.194:8080/job/DynamoRIO-AArch64-Precommit/887/console

171/176 Test #168: code_api|tool.histogram.offline .................***Failed    2.98 sec
Running cmd |/var/lib/jenkins/.jenkins/workspace/DynamoRIO-AArch64-Precommit/build/build_debug-internal-64/bin64/drrun;-s;90;-quiet;-debug;-killpg;-stderr_mask;0xC;-dumpcore_mask;0;-code_api;-t;drcachesim;-offline;-subdir_prefix;tool.histogram.offline;--;/var/lib/jenkins/.jenkins/workspace/DynamoRIO-AArch64-Precommit/build/build_debug-internal-64/suite/tests/bin/pthreads.ptsig|
Running postcmd |/var/lib/jenkins/.jenkins/workspace/DynamoRIO-AArch64-Precommit/build/build_debug-internal-64/clients/bin64/drcachesim;-indir;/var/lib/jenkins/.jenkins/workspace/DynamoRIO-AArch64-Precommit/build/build_debug-internal-64/suite/tests/tool.histogram.offline.pthreads.ptsig.03302.8806.dir|
Running postcmd2 |/var/lib/jenkins/.jenkins/workspace/DynamoRIO-AArch64-Precommit/build/build_debug-internal-64/clients/bin64/histogram_launcher;-test_mode;-trace_dir;/var/lib/jenkins/.jenkins/workspace/DynamoRIO-AArch64-Precommit/build/build_debug-internal-64/suite/tests/tool.histogram.offline.pthreads.ptsig.03302.8806.dir/trace|
CMake Error at /var/lib/jenkins/.jenkins/workspace/DynamoRIO-AArch64-Precommit/suite/tests/runmulti.cmake:106 (message):
  *** postcmd2 failed (Child aborted): histogram_launcher:
  /var/lib/jenkins/.jenkins/workspace/DynamoRIO-AArch64-Precommit/clients/drcachesim/tests/trace_invariants.cpp:143:
  virtual bool trace_invariants_t::process_memref(const memref_t&): Assertion
  `memref.instr.tid != pre_signal_instr.instr.tid || memref.instr.addr ==
  pre_signal_instr.instr.addr || memref.instr.addr ==
  pre_signal_instr.instr.addr + pre_signal_instr.instr.size ||
  memref.instr.addr == app_handler_pc ||
  type_is_instr_branch(pre_signal_instr.instr.type) ||
  pre_signal_instr.instr.type == TRACE_TYPE_INSTR_SYSENTER' failed.

  ***
@derekbruening
Copy link
Contributor Author

A similar invariant (is it the same one after code changes?) just failed on 32-bit Travis:
https://travis-ci.com/DynamoRIO/dynamorio/jobs/273998434


1225273/322 Test #274: code_api|tool.histogram.offline ..................................***Failed    2.98 sec
1226Running cmd |/home/travis/build/DynamoRIO/dynamorio/build_debug-internal-32/bin32/drrun;-s;90;-quiet;-debug;-killpg;-stderr_mask;0xC;-dumpcore_mask;0;-code_api;-t;drcachesim;-offline;-subdir_prefix;tool.histogram.offline;--;/home/travis/build/DynamoRIO/dynamorio/build_debug-internal-32/suite/tests/bin/drmemtrace.signal_invariants|
1227Running postcmd |/home/travis/build/DynamoRIO/dynamorio/build_debug-internal-32/clients/bin32/drcachesim;-indir;/home/travis/build/DynamoRIO/dynamorio/build_debug-internal-32/suite/tests/tool.histogram.offline.drmemtrace.signal_invariants.20715.6317.dir|
1228Running postcmd2 |/home/travis/build/DynamoRIO/dynamorio/build_debug-internal-32/clients/bin32/histogram_launcher;-test_mode;-trace_dir;/home/travis/build/DynamoRIO/dynamorio/build_debug-internal-32/suite/tests/tool.histogram.offline.drmemtrace.signal_invariants.20715.6317.dir/trace|
1229CMake Error at /home/travis/build/DynamoRIO/dynamorio/suite/tests/runmulti.cmake:106 (message):
1230  *** postcmd2 failed (Child aborted): histogram_launcher:
1231  /home/travis/build/DynamoRIO/dynamorio/clients/drcachesim/tests/trace_invariants.cpp:111:
1232  virtual bool trace_invariants_t::process_memref(const memref_t&): Assertion
1233  `prev_instr.instr.tid == memref.instr.tid ||
1234  thread_exited[prev_instr.instr.tid] || (prev_xfer_marker.instr.tid ==
1235  prev_instr.instr.tid && prev_xfer_marker.marker.marker_type ==
1236  TRACE_MARKER_TYPE_KERNEL_EVENT)' failed.
1237
1238  ***

@derekbruening
Copy link
Contributor Author

Failing a lot recently. E.g.: http://139.178.83.194:8080/job/DynamoRIO-AArch64-Precommit/927/

@derekbruening
Copy link
Contributor Author

Travis failure just hit again: https://travis-ci.com/DynamoRIO/dynamorio/jobs/274359971

@AssadHashmi AssadHashmi self-assigned this Jan 22, 2020
derekbruening added a commit that referenced this issue Mar 6, 2020
Adds drcachesim.invariants (i#2982) and tool.histogram.offline
(i#3980) to the tests whose failures are ignored, until we can
reproduce and fix them.

Issue: #2892, #3980
derekbruening added a commit that referenced this issue Mar 6, 2020
Adds drcachesim.invariants (i#2982) and tool.histogram.offline
(i#3980) to the tests whose failures are ignored, until we can
reproduce and fix them.

Issue: #2892, #3980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants