i#4075: Fix deadlock on double takeover #4080
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a double-takeover deadlock by changing
nt_wait_event_with_timeout() to use a raw syscall to keep the PC in
dynamorio.dll for os_take_over_all_unknown_threads() (and synch_with_*
and other routines) to more easily identify a thread in DR code. In
particular this is required to avoid a double takeover on a race
between intercept_new_thread() and os_take_over_all_unknown_threads().
Fixes #4075