i#4123: Look for symbols in special build-id subdir #4133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds to drsyms reading of the build id and searching in /usr/lib/debug/.build-id for a separate debuginfo file, which is the modern scheme for installed libraries. Tested on internal symbols like __GI___libc_malloc on a local machine. It is not easy to make an automated test for this without setting up a chroot or something which does not seem worth the effort. Fixes #4123
snehasish
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds to drsyms reading of the build id and searching in
/usr/lib/debug/.build-id for a separate debuginfo file, which is the
modern scheme for installed libraries.
Tested on internal symbols like __GI___libc_malloc on a local machine.
It is not easy to make an automated test for this without setting up a
chroot or something which does not seem worth the effort.
Fixes #4123