i#3978: Fix decode_cti bug on particular (e)vex byte sequences #3979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug in decode_cti() with a (e)vex prefix with its 2nd or 3rd byte also looking like the first byte of a (e)vex prefix where the instruction is considered invalid, crashing the application. Adds testing of decode_cti() to api.ir by export decode_cti() in DEBUG and BUILD_TESTS builds. Adds a test case that triggers the observed bug without the fix. Fixes #3978
|
Wow our CI is not in a good place: all 3 failures look like flakes. |
p0wer0xff
added a commit
to siemens/fluffi
that referenced
this pull request
Dec 12, 2019
include patch DynamoRIO/dynamorio#3979 to fix issue DynamoRIO/dynamorio#3978 due to AVX-512 instruction support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in decode_cti() with a (e)vex prefix with its 2nd or 3rd
byte also looking like the first byte of a (e)vex prefix where the
instruction is considered invalid, crashing the application.
Adds testing of decode_cti() to api.ir by export decode_cti() in DEBUG
and BUILD_TESTS builds. Adds a test case that triggers the observed
bug without the fix.
Fixes #3978