Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.19.1 disable network traffic #14393

Merged
merged 8 commits into from
Sep 11, 2023
Merged

2.19.1 disable network traffic #14393

merged 8 commits into from
Sep 11, 2023

Conversation

mjkkirschner
Copy link
Member

@mjkkirschner mjkkirschner commented Sep 8, 2023 •
edited
Loading

This pulls in some changes from @pinzart90's changes for 2.17.4 and tries to adapt them to use the DisableAnalytics flag as a stand in DisableNetworkActivity flag until we have that.

Additionally, it disables the notification center requests if DisableAnalytics is true.

I believe it is safe to merge to master, unlike the original changes.

pinzart90 and others added 5 commits September 8, 2023 09:52
@pinzart90 @pinzart @mjkkirschner
cherry pick analytics issue (#13328)
f799885 
* update

* update

* null checking

* update

* Update CoreNodeModelWpfResources.Designer.cs

Co-authored-by: pinzart <[email protected]>
@pinzart @mjkkirschner
Revert "cherry pick analytics issue (#13328)"
97fe2f8 
This reverts commit 6f9761d.
@pinzart90 @pinzart @mjkkirschner
cherry pick analytics issue (#13328) (#14085)
09212a0 
* update

* update

* null checking

* update

* Update CoreNodeModelWpfResources.Designer.cs

Co-authored-by: pinzart <[email protected]>
@pinzart90 @pinzart @mjkkirschner
Disable net traffic (#14083)
d249dba 
* disable net traffic example

* Update PackageManagerViewExtension.cs

* update

* Update DynamoModel.cs

* Update PackageManagerViewExtension.cs

* Update PackageManagerViewExtension.cs

---------

Co-authored-by: pinzart <[email protected]>
@pinzart90 @pinzart @mjkkirschner
Update PreferencesViewModel.cs: crash due to null feature flags (#14087)
425b404 
* Update PreferencesViewModel.cs

* Update PackageManagerViewExtensionTests.cs

---------

Co-authored-by: pinzart <[email protected]>
@github-actions
Copy link

github-actions bot commented Sep 8, 2023 •
edited
Loading

⚠️ [run-bin-diff] - Files Added/Deleted::75 new file(s) have been added and 153 file(s) have been deleted!
⚠️ [run-bin-diff-net60-windows] - Files Added/Deleted::15 new file(s) have been added and 29 file(s) have been deleted!
(Updated: 2023-09-11-15:15:34)

@QilongTang QilongTang changed the title 219disablenet WIP 219 disable network traffic WIP Sep 11, 2023
@QilongTang QilongTang changed the base branch from RC2.19.0_master to RC2.19.1_master September 11, 2023 14:41
@QilongTang QilongTang added this to the 2.19.1 milestone Sep 11, 2023
@QilongTang
Copy link
Contributor

@mjkkirschner All changes looks good, this is no longer WIP right?

@QilongTang QilongTang changed the title 219 disable network traffic WIP 2.19.1 disable network traffic WIP Sep 11, 2023
@mjkkirschner
Copy link
Member Author

@QilongTang let me make a few last updates to this!

@mjkkirschner
Copy link
Member Author

mjkkirschner commented Sep 11, 2023 •
edited
Loading

@QilongTang @sm6srw PTAL - I added some TODO comments and also disabled the notifications center if the DisableAnalytics static props was set true.

I think this should be safe to merge to master as well so we can stop doing these one off builds in the future.

sm6srw
sm6srw approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@sm6srw sm6srw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@QilongTang
Copy link
Contributor

@QilongTang @sm6srw PTAL - I added some TODO comments and also disabled the notifications center if the DisableAnalytics static props was set true.

I think this should be safe to merge to master as well so we can stop doing these one off builds in the future.

Thanks, nicely done

@QilongTang QilongTang merged commit bb0f4b2 into RC2.19.1_master Sep 11, 2023
@QilongTang QilongTang deleted the 219disablenet branch September 11, 2023 15:25
@mjkkirschner
Copy link
Member Author

mjkkirschner commented Sep 11, 2023 •
edited
Loading

@QilongTang I was hoping we'd wait for the tests to pass 😬 - I will keep an eye on them.

@QilongTang
Copy link
Contributor

QilongTang commented Sep 11, 2023 •
edited
Loading

@mjkkirschner The previous job does have tests passed and given we have no tests for notification center, I merged. I will have another PR to update release version etc

mjkkirschner added a commit to mjkkirschner/Dynamo that referenced this pull request Sep 11, 2023
@mjkkirschner @pinzart90 @pinzart
2.19.1 disable network traffic WIP (DynamoDS#14393)
9110d49 
* cherry pick analytics issue (DynamoDS#13328)

* update

* update

* null checking

* update

* Update CoreNodeModelWpfResources.Designer.cs

Co-authored-by: pinzart <[email protected]>

* Revert "cherry pick analytics issue (DynamoDS#13328)"

This reverts commit 6f9761d.

* cherry pick analytics issue (DynamoDS#13328) (DynamoDS#14085)

* update

* update

* null checking

* update

* Update CoreNodeModelWpfResources.Designer.cs

Co-authored-by: pinzart <[email protected]>

* Disable net traffic (DynamoDS#14083)

* disable net traffic example

* Update PackageManagerViewExtension.cs

* update

* Update DynamoModel.cs

* Update PackageManagerViewExtension.cs

* Update PackageManagerViewExtension.cs

---------

Co-authored-by: pinzart <[email protected]>

* Update PreferencesViewModel.cs: crash due to null feature flags (DynamoDS#14087)

* Update PreferencesViewModel.cs

* Update PackageManagerViewExtensionTests.cs

---------

Co-authored-by: pinzart <[email protected]>

* changes

* remove comment

* comments and disable notifications

---------

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>
mjkkirschner added a commit that referenced this pull request Sep 11, 2023
@mjkkirschner @pinzart90 @pinzart
disable network traffic using DisableAnalytics flag (#14399)
549bfd3 
* fix most memory leaks from opening and closing Dynamo Splash Screen (#14344)

* fixing mem leaks in progress

* fix test and remove todo

* 2.19.1 disable network traffic WIP (#14393)

* cherry pick analytics issue (#13328)

* update

* update

* null checking

* update

* Update CoreNodeModelWpfResources.Designer.cs

Co-authored-by: pinzart <[email protected]>

* Revert "cherry pick analytics issue (#13328)"

This reverts commit 6f9761d.

* cherry pick analytics issue (#13328) (#14085)

* update

* update

* null checking

* update

* Update CoreNodeModelWpfResources.Designer.cs

Co-authored-by: pinzart <[email protected]>

* Disable net traffic (#14083)

* disable net traffic example

* Update PackageManagerViewExtension.cs

* update

* Update DynamoModel.cs

* Update PackageManagerViewExtension.cs

* Update PackageManagerViewExtension.cs

---------

Co-authored-by: pinzart <[email protected]>

* Update PreferencesViewModel.cs: crash due to null feature flags (#14087)

* Update PreferencesViewModel.cs

* Update PackageManagerViewExtensionTests.cs

---------

Co-authored-by: pinzart <[email protected]>

* changes

* remove comment

* comments and disable notifications

---------

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>

---------

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>
@QilongTang QilongTang changed the title 2.19.1 disable network traffic WIP 2.19.1 disable network traffic Sep 11, 2023
mjkkirschner added a commit that referenced this pull request Sep 19, 2023
@mjkkirschner @pinzart90 @pinzart
Add DynamoPythonTests to sln (#14407)
120adc7 
* fix most memory leaks from opening and closing Dynamo Splash Screen (#14344)

* fixing mem leaks in progress

* fix test and remove todo

* 2.19.1 disable network traffic WIP (#14393)

* cherry pick analytics issue (#13328)

* update

* update

* null checking

* update

* Update CoreNodeModelWpfResources.Designer.cs

Co-authored-by: pinzart <[email protected]>

* Revert "cherry pick analytics issue (#13328)"

This reverts commit 6f9761d.

* cherry pick analytics issue (#13328) (#14085)

* update

* update

* null checking

* update

* Update CoreNodeModelWpfResources.Designer.cs

Co-authored-by: pinzart <[email protected]>

* Disable net traffic (#14083)

* disable net traffic example

* Update PackageManagerViewExtension.cs

* update

* Update DynamoModel.cs

* Update PackageManagerViewExtension.cs

* Update PackageManagerViewExtension.cs

---------

Co-authored-by: pinzart <[email protected]>

* Update PreferencesViewModel.cs: crash due to null feature flags (#14087)

* Update PreferencesViewModel.cs

* Update PackageManagerViewExtensionTests.cs

---------

Co-authored-by: pinzart <[email protected]>

* changes

* remove comment

* comments and disable notifications

---------

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>

* add python tests

* move project

* revert

---------

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>
pinzart90 added a commit that referenced this pull request Oct 28, 2023
@mjkkirschner @pinzart90 @pinzart
2.19.1 disable network traffic WIP (#14393)
ea6ab78 
* cherry pick analytics issue (#13328)

* update

* update

* null checking

* update

* Update CoreNodeModelWpfResources.Designer.cs

Co-authored-by: pinzart <[email protected]>

* Revert "cherry pick analytics issue (#13328)"

This reverts commit 6f9761d.

* cherry pick analytics issue (#13328) (#14085)

* update

* update

* null checking

* update

* Update CoreNodeModelWpfResources.Designer.cs

Co-authored-by: pinzart <[email protected]>

* Disable net traffic (#14083)

* disable net traffic example

* Update PackageManagerViewExtension.cs

* update

* Update DynamoModel.cs

* Update PackageManagerViewExtension.cs

* Update PackageManagerViewExtension.cs

---------

Co-authored-by: pinzart <[email protected]>

* Update PreferencesViewModel.cs: crash due to null feature flags (#14087)

* Update PreferencesViewModel.cs

* Update PackageManagerViewExtensionTests.cs

---------

Co-authored-by: pinzart <[email protected]>

* changes

* remove comment

* comments and disable notifications

---------

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sm6srw sm6srw sm6srw approved these changes

@QilongTang QilongTang QilongTang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.19.1
Development

Successfully merging this pull request may close these issues.
5 participants
@mjkkirschner @QilongTang @sm6srw @pinzart90 @pinzart