Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PreferencesViewModel.cs: crash due to null feature flags #14087

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

pinzart90
Copy link
Contributor

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

(FILL ME IN) This section describes why this PR is here. Usually it would include a reference
to the tracking task that it is part or all of the solution for.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@pinzart90 pinzart90 requested a review from QilongTang June 16, 2023 16:24
@QilongTang
Copy link
Contributor

@pinzart90 As we discussed, there are two regressions on this branch to resolve before any build can be posted

@QilongTang QilongTang added this to the 2.17.4 milestone Jun 16, 2023
@QilongTang QilongTang merged commit fee48dd into RC2.17.4_master Jun 16, 2023
@QilongTang QilongTang deleted the fix_crash branch June 16, 2023 18:47
sm6srw pushed a commit to sm6srw/Dynamo that referenced this pull request Sep 8, 2023
…moDS#14087)

* Update PreferencesViewModel.cs

* Update PackageManagerViewExtensionTests.cs

---------

Co-authored-by: pinzart <[email protected]>
mjkkirschner pushed a commit that referenced this pull request Sep 8, 2023
* Update PreferencesViewModel.cs

* Update PackageManagerViewExtensionTests.cs

---------

Co-authored-by: pinzart <[email protected]>
QilongTang pushed a commit that referenced this pull request Sep 11, 2023
* cherry pick analytics issue (#13328)

* update

* update

* null checking

* update

* Update CoreNodeModelWpfResources.Designer.cs

Co-authored-by: pinzart <[email protected]>

* Revert "cherry pick analytics issue (#13328)"

This reverts commit 6f9761d.

* cherry pick analytics issue (#13328) (#14085)

* update

* update

* null checking

* update

* Update CoreNodeModelWpfResources.Designer.cs

Co-authored-by: pinzart <[email protected]>

* Disable net traffic (#14083)

* disable net traffic example

* Update PackageManagerViewExtension.cs

* update

* Update DynamoModel.cs

* Update PackageManagerViewExtension.cs

* Update PackageManagerViewExtension.cs

---------

Co-authored-by: pinzart <[email protected]>

* Update PreferencesViewModel.cs: crash due to null feature flags (#14087)

* Update PreferencesViewModel.cs

* Update PackageManagerViewExtensionTests.cs

---------

Co-authored-by: pinzart <[email protected]>

* changes

* remove comment

* comments and disable notifications

---------

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>
mjkkirschner added a commit to mjkkirschner/Dynamo that referenced this pull request Sep 11, 2023
* cherry pick analytics issue (DynamoDS#13328)

* update

* update

* null checking

* update

* Update CoreNodeModelWpfResources.Designer.cs

Co-authored-by: pinzart <[email protected]>

* Revert "cherry pick analytics issue (DynamoDS#13328)"

This reverts commit 6f9761d.

* cherry pick analytics issue (DynamoDS#13328) (DynamoDS#14085)

* update

* update

* null checking

* update

* Update CoreNodeModelWpfResources.Designer.cs

Co-authored-by: pinzart <[email protected]>

* Disable net traffic (DynamoDS#14083)

* disable net traffic example

* Update PackageManagerViewExtension.cs

* update

* Update DynamoModel.cs

* Update PackageManagerViewExtension.cs

* Update PackageManagerViewExtension.cs

---------

Co-authored-by: pinzart <[email protected]>

* Update PreferencesViewModel.cs: crash due to null feature flags (DynamoDS#14087)

* Update PreferencesViewModel.cs

* Update PackageManagerViewExtensionTests.cs

---------

Co-authored-by: pinzart <[email protected]>

* changes

* remove comment

* comments and disable notifications

---------

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>
mjkkirschner added a commit that referenced this pull request Sep 11, 2023
* fix most memory leaks from opening and closing Dynamo Splash Screen (#14344)

* fixing mem leaks in progress

* fix test and remove todo

* 2.19.1 disable network traffic WIP (#14393)

* cherry pick analytics issue (#13328)

* update

* update

* null checking

* update

* Update CoreNodeModelWpfResources.Designer.cs

Co-authored-by: pinzart <[email protected]>

* Revert "cherry pick analytics issue (#13328)"

This reverts commit 6f9761d.

* cherry pick analytics issue (#13328) (#14085)

* update

* update

* null checking

* update

* Update CoreNodeModelWpfResources.Designer.cs

Co-authored-by: pinzart <[email protected]>

* Disable net traffic (#14083)

* disable net traffic example

* Update PackageManagerViewExtension.cs

* update

* Update DynamoModel.cs

* Update PackageManagerViewExtension.cs

* Update PackageManagerViewExtension.cs

---------

Co-authored-by: pinzart <[email protected]>

* Update PreferencesViewModel.cs: crash due to null feature flags (#14087)

* Update PreferencesViewModel.cs

* Update PackageManagerViewExtensionTests.cs

---------

Co-authored-by: pinzart <[email protected]>

* changes

* remove comment

* comments and disable notifications

---------

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>

---------

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>
mjkkirschner added a commit that referenced this pull request Sep 19, 2023
* fix most memory leaks from opening and closing Dynamo Splash Screen (#14344)

* fixing mem leaks in progress

* fix test and remove todo

* 2.19.1 disable network traffic WIP (#14393)

* cherry pick analytics issue (#13328)

* update

* update

* null checking

* update

* Update CoreNodeModelWpfResources.Designer.cs

Co-authored-by: pinzart <[email protected]>

* Revert "cherry pick analytics issue (#13328)"

This reverts commit 6f9761d.

* cherry pick analytics issue (#13328) (#14085)

* update

* update

* null checking

* update

* Update CoreNodeModelWpfResources.Designer.cs

Co-authored-by: pinzart <[email protected]>

* Disable net traffic (#14083)

* disable net traffic example

* Update PackageManagerViewExtension.cs

* update

* Update DynamoModel.cs

* Update PackageManagerViewExtension.cs

* Update PackageManagerViewExtension.cs

---------

Co-authored-by: pinzart <[email protected]>

* Update PreferencesViewModel.cs: crash due to null feature flags (#14087)

* Update PreferencesViewModel.cs

* Update PackageManagerViewExtensionTests.cs

---------

Co-authored-by: pinzart <[email protected]>

* changes

* remove comment

* comments and disable notifications

---------

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>

* add python tests

* move project

* revert

---------

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>
pinzart90 added a commit that referenced this pull request Oct 28, 2023
* cherry pick analytics issue (#13328)

* update

* update

* null checking

* update

* Update CoreNodeModelWpfResources.Designer.cs

Co-authored-by: pinzart <[email protected]>

* Revert "cherry pick analytics issue (#13328)"

This reverts commit 6f9761d.

* cherry pick analytics issue (#13328) (#14085)

* update

* update

* null checking

* update

* Update CoreNodeModelWpfResources.Designer.cs

Co-authored-by: pinzart <[email protected]>

* Disable net traffic (#14083)

* disable net traffic example

* Update PackageManagerViewExtension.cs

* update

* Update DynamoModel.cs

* Update PackageManagerViewExtension.cs

* Update PackageManagerViewExtension.cs

---------

Co-authored-by: pinzart <[email protected]>

* Update PreferencesViewModel.cs: crash due to null feature flags (#14087)

* Update PreferencesViewModel.cs

* Update PackageManagerViewExtensionTests.cs

---------

Co-authored-by: pinzart <[email protected]>

* changes

* remove comment

* comments and disable notifications

---------

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants