Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable net traffic #14083

Merged
merged 6 commits into from
Jun 16, 2023
Merged

Disable net traffic #14083

merged 6 commits into from
Jun 16, 2023

Conversation

pinzart90
Copy link
Contributor

@pinzart90 pinzart90 commented Jun 16, 2023

To achieve network blackout this is what I had to do:

  • DynamoSandbox started with disableAnalytics flag and notification + autocomplete disabled in UI.
  • DefaultUpdateManager.DisableUpdates set to true
  • changes in this PR

@pinzart90 pinzart90 changed the base branch from master to RC2.17.3_master June 16, 2023 04:35
@pinzart90 pinzart90 requested review from mjkkirschner, zeusongit and QilongTang and removed request for zeusongit June 16, 2023 14:19
@pinzart90 pinzart90 marked this pull request as ready for review June 16, 2023 14:19
@pinzart90 pinzart90 changed the base branch from RC2.17.3_master to RC2.17.4_master June 16, 2023 14:23
@@ -138,6 +138,9 @@ private void RequestLoadViewExtensionsForLoadedPackages(IEnumerable<Package> pac

private void RaisePackageHostNotifications(IEnumerable<Package> packages)
{
// ALIAS does needs a total network traffic blackout.
// Since there is no way to switch this on/off, we will just skip it for now.
/*
foreach (var pkg in packages)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code would not raise network traffic right? This is the code to check if the installed package is targetting other host. I think @zeusongit recently worked on it..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented it out because it did try to contact pacakage manager.
I could not find a way to disable through API or configs. @zeusongit any idea if there is a way to disable this ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reading the code, I can see why now. In function CheckIfPackagesTargetOtherHosts there is a call var knownHosts = PackageManagerClient.GetKnownHosts(); which will contact package manager

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this solution is fine for now but we probably want to guard all of these code using the env variable or setting property on master branch.

@pinzart90 pinzart90 requested a review from zeusongit June 16, 2023 14:53
@QilongTang
Copy link
Contributor

Are there code changes related to DefaultUpdateManager.DisableUpdates set to true?

@pinzart90
Copy link
Contributor Author

pinzart90 commented Jun 16, 2023

DisableUpdates

Only locally, to reflect the changes in the ALIAS repo
From the ALIAS repo:

class UpdateManagerConfig : IUpdateManagerConfiguration, IDisableUpdateConfig
...
        public bool DisableUpdates
        {
            get { return true; }
            set { }
        }

@pinzart90 pinzart90 requested a review from QilongTang June 16, 2023 15:00
@QilongTang QilongTang added this to the 2.17.4 milestone Jun 16, 2023
@QilongTang QilongTang merged commit 405e8bc into RC2.17.4_master Jun 16, 2023
@QilongTang QilongTang deleted the disable_net_traffic branch June 16, 2023 15:13
sm6srw pushed a commit to sm6srw/Dynamo that referenced this pull request Sep 8, 2023
* disable net traffic example

* Update PackageManagerViewExtension.cs

* update

* Update DynamoModel.cs

* Update PackageManagerViewExtension.cs

* Update PackageManagerViewExtension.cs

---------

Co-authored-by: pinzart <[email protected]>
mjkkirschner pushed a commit that referenced this pull request Sep 8, 2023
* disable net traffic example

* Update PackageManagerViewExtension.cs

* update

* Update DynamoModel.cs

* Update PackageManagerViewExtension.cs

* Update PackageManagerViewExtension.cs

---------

Co-authored-by: pinzart <[email protected]>
QilongTang pushed a commit that referenced this pull request Sep 11, 2023
* cherry pick analytics issue (#13328)

* update

* update

* null checking

* update

* Update CoreNodeModelWpfResources.Designer.cs

Co-authored-by: pinzart <[email protected]>

* Revert "cherry pick analytics issue (#13328)"

This reverts commit 6f9761d.

* cherry pick analytics issue (#13328) (#14085)

* update

* update

* null checking

* update

* Update CoreNodeModelWpfResources.Designer.cs

Co-authored-by: pinzart <[email protected]>

* Disable net traffic (#14083)

* disable net traffic example

* Update PackageManagerViewExtension.cs

* update

* Update DynamoModel.cs

* Update PackageManagerViewExtension.cs

* Update PackageManagerViewExtension.cs

---------

Co-authored-by: pinzart <[email protected]>

* Update PreferencesViewModel.cs: crash due to null feature flags (#14087)

* Update PreferencesViewModel.cs

* Update PackageManagerViewExtensionTests.cs

---------

Co-authored-by: pinzart <[email protected]>

* changes

* remove comment

* comments and disable notifications

---------

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>
mjkkirschner added a commit to mjkkirschner/Dynamo that referenced this pull request Sep 11, 2023
* cherry pick analytics issue (DynamoDS#13328)

* update

* update

* null checking

* update

* Update CoreNodeModelWpfResources.Designer.cs

Co-authored-by: pinzart <[email protected]>

* Revert "cherry pick analytics issue (DynamoDS#13328)"

This reverts commit 6f9761d.

* cherry pick analytics issue (DynamoDS#13328) (DynamoDS#14085)

* update

* update

* null checking

* update

* Update CoreNodeModelWpfResources.Designer.cs

Co-authored-by: pinzart <[email protected]>

* Disable net traffic (DynamoDS#14083)

* disable net traffic example

* Update PackageManagerViewExtension.cs

* update

* Update DynamoModel.cs

* Update PackageManagerViewExtension.cs

* Update PackageManagerViewExtension.cs

---------

Co-authored-by: pinzart <[email protected]>

* Update PreferencesViewModel.cs: crash due to null feature flags (DynamoDS#14087)

* Update PreferencesViewModel.cs

* Update PackageManagerViewExtensionTests.cs

---------

Co-authored-by: pinzart <[email protected]>

* changes

* remove comment

* comments and disable notifications

---------

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>
mjkkirschner added a commit that referenced this pull request Sep 11, 2023
* fix most memory leaks from opening and closing Dynamo Splash Screen (#14344)

* fixing mem leaks in progress

* fix test and remove todo

* 2.19.1 disable network traffic WIP (#14393)

* cherry pick analytics issue (#13328)

* update

* update

* null checking

* update

* Update CoreNodeModelWpfResources.Designer.cs

Co-authored-by: pinzart <[email protected]>

* Revert "cherry pick analytics issue (#13328)"

This reverts commit 6f9761d.

* cherry pick analytics issue (#13328) (#14085)

* update

* update

* null checking

* update

* Update CoreNodeModelWpfResources.Designer.cs

Co-authored-by: pinzart <[email protected]>

* Disable net traffic (#14083)

* disable net traffic example

* Update PackageManagerViewExtension.cs

* update

* Update DynamoModel.cs

* Update PackageManagerViewExtension.cs

* Update PackageManagerViewExtension.cs

---------

Co-authored-by: pinzart <[email protected]>

* Update PreferencesViewModel.cs: crash due to null feature flags (#14087)

* Update PreferencesViewModel.cs

* Update PackageManagerViewExtensionTests.cs

---------

Co-authored-by: pinzart <[email protected]>

* changes

* remove comment

* comments and disable notifications

---------

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>

---------

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>
mjkkirschner added a commit that referenced this pull request Sep 19, 2023
* fix most memory leaks from opening and closing Dynamo Splash Screen (#14344)

* fixing mem leaks in progress

* fix test and remove todo

* 2.19.1 disable network traffic WIP (#14393)

* cherry pick analytics issue (#13328)

* update

* update

* null checking

* update

* Update CoreNodeModelWpfResources.Designer.cs

Co-authored-by: pinzart <[email protected]>

* Revert "cherry pick analytics issue (#13328)"

This reverts commit 6f9761d.

* cherry pick analytics issue (#13328) (#14085)

* update

* update

* null checking

* update

* Update CoreNodeModelWpfResources.Designer.cs

Co-authored-by: pinzart <[email protected]>

* Disable net traffic (#14083)

* disable net traffic example

* Update PackageManagerViewExtension.cs

* update

* Update DynamoModel.cs

* Update PackageManagerViewExtension.cs

* Update PackageManagerViewExtension.cs

---------

Co-authored-by: pinzart <[email protected]>

* Update PreferencesViewModel.cs: crash due to null feature flags (#14087)

* Update PreferencesViewModel.cs

* Update PackageManagerViewExtensionTests.cs

---------

Co-authored-by: pinzart <[email protected]>

* changes

* remove comment

* comments and disable notifications

---------

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>

* add python tests

* move project

* revert

---------

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>
pinzart90 added a commit that referenced this pull request Oct 28, 2023
* cherry pick analytics issue (#13328)

* update

* update

* null checking

* update

* Update CoreNodeModelWpfResources.Designer.cs

Co-authored-by: pinzart <[email protected]>

* Revert "cherry pick analytics issue (#13328)"

This reverts commit 6f9761d.

* cherry pick analytics issue (#13328) (#14085)

* update

* update

* null checking

* update

* Update CoreNodeModelWpfResources.Designer.cs

Co-authored-by: pinzart <[email protected]>

* Disable net traffic (#14083)

* disable net traffic example

* Update PackageManagerViewExtension.cs

* update

* Update DynamoModel.cs

* Update PackageManagerViewExtension.cs

* Update PackageManagerViewExtension.cs

---------

Co-authored-by: pinzart <[email protected]>

* Update PreferencesViewModel.cs: crash due to null feature flags (#14087)

* Update PreferencesViewModel.cs

* Update PackageManagerViewExtensionTests.cs

---------

Co-authored-by: pinzart <[email protected]>

* changes

* remove comment

* comments and disable notifications

---------

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants