-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable net traffic #14083
Disable net traffic #14083
Conversation
@@ -138,6 +138,9 @@ private void RequestLoadViewExtensionsForLoadedPackages(IEnumerable<Package> pac | |||
|
|||
private void RaisePackageHostNotifications(IEnumerable<Package> packages) | |||
{ | |||
// ALIAS does needs a total network traffic blackout. | |||
// Since there is no way to switch this on/off, we will just skip it for now. | |||
/* | |||
foreach (var pkg in packages) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code would not raise network traffic right? This is the code to check if the installed package is targetting other host. I think @zeusongit recently worked on it..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I commented it out because it did try to contact pacakage manager.
I could not find a way to disable through API or configs. @zeusongit any idea if there is a way to disable this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reading the code, I can see why now. In function CheckIfPackagesTargetOtherHosts
there is a call var knownHosts = PackageManagerClient.GetKnownHosts();
which will contact package manager
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this solution is fine for now but we probably want to guard all of these code using the env variable or setting property on master
branch.
Are there code changes related to |
Only locally, to reflect the changes in the ALIAS repo
|
* disable net traffic example * Update PackageManagerViewExtension.cs * update * Update DynamoModel.cs * Update PackageManagerViewExtension.cs * Update PackageManagerViewExtension.cs --------- Co-authored-by: pinzart <[email protected]>
* disable net traffic example * Update PackageManagerViewExtension.cs * update * Update DynamoModel.cs * Update PackageManagerViewExtension.cs * Update PackageManagerViewExtension.cs --------- Co-authored-by: pinzart <[email protected]>
* cherry pick analytics issue (#13328) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Revert "cherry pick analytics issue (#13328)" This reverts commit 6f9761d. * cherry pick analytics issue (#13328) (#14085) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Disable net traffic (#14083) * disable net traffic example * Update PackageManagerViewExtension.cs * update * Update DynamoModel.cs * Update PackageManagerViewExtension.cs * Update PackageManagerViewExtension.cs --------- Co-authored-by: pinzart <[email protected]> * Update PreferencesViewModel.cs: crash due to null feature flags (#14087) * Update PreferencesViewModel.cs * Update PackageManagerViewExtensionTests.cs --------- Co-authored-by: pinzart <[email protected]> * changes * remove comment * comments and disable notifications --------- Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]>
* cherry pick analytics issue (DynamoDS#13328) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Revert "cherry pick analytics issue (DynamoDS#13328)" This reverts commit 6f9761d. * cherry pick analytics issue (DynamoDS#13328) (DynamoDS#14085) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Disable net traffic (DynamoDS#14083) * disable net traffic example * Update PackageManagerViewExtension.cs * update * Update DynamoModel.cs * Update PackageManagerViewExtension.cs * Update PackageManagerViewExtension.cs --------- Co-authored-by: pinzart <[email protected]> * Update PreferencesViewModel.cs: crash due to null feature flags (DynamoDS#14087) * Update PreferencesViewModel.cs * Update PackageManagerViewExtensionTests.cs --------- Co-authored-by: pinzart <[email protected]> * changes * remove comment * comments and disable notifications --------- Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]>
* fix most memory leaks from opening and closing Dynamo Splash Screen (#14344) * fixing mem leaks in progress * fix test and remove todo * 2.19.1 disable network traffic WIP (#14393) * cherry pick analytics issue (#13328) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Revert "cherry pick analytics issue (#13328)" This reverts commit 6f9761d. * cherry pick analytics issue (#13328) (#14085) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Disable net traffic (#14083) * disable net traffic example * Update PackageManagerViewExtension.cs * update * Update DynamoModel.cs * Update PackageManagerViewExtension.cs * Update PackageManagerViewExtension.cs --------- Co-authored-by: pinzart <[email protected]> * Update PreferencesViewModel.cs: crash due to null feature flags (#14087) * Update PreferencesViewModel.cs * Update PackageManagerViewExtensionTests.cs --------- Co-authored-by: pinzart <[email protected]> * changes * remove comment * comments and disable notifications --------- Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]> --------- Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]>
* fix most memory leaks from opening and closing Dynamo Splash Screen (#14344) * fixing mem leaks in progress * fix test and remove todo * 2.19.1 disable network traffic WIP (#14393) * cherry pick analytics issue (#13328) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Revert "cherry pick analytics issue (#13328)" This reverts commit 6f9761d. * cherry pick analytics issue (#13328) (#14085) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Disable net traffic (#14083) * disable net traffic example * Update PackageManagerViewExtension.cs * update * Update DynamoModel.cs * Update PackageManagerViewExtension.cs * Update PackageManagerViewExtension.cs --------- Co-authored-by: pinzart <[email protected]> * Update PreferencesViewModel.cs: crash due to null feature flags (#14087) * Update PreferencesViewModel.cs * Update PackageManagerViewExtensionTests.cs --------- Co-authored-by: pinzart <[email protected]> * changes * remove comment * comments and disable notifications --------- Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]> * add python tests * move project * revert --------- Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]>
* cherry pick analytics issue (#13328) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Revert "cherry pick analytics issue (#13328)" This reverts commit 6f9761d. * cherry pick analytics issue (#13328) (#14085) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Disable net traffic (#14083) * disable net traffic example * Update PackageManagerViewExtension.cs * update * Update DynamoModel.cs * Update PackageManagerViewExtension.cs * Update PackageManagerViewExtension.cs --------- Co-authored-by: pinzart <[email protected]> * Update PreferencesViewModel.cs: crash due to null feature flags (#14087) * Update PreferencesViewModel.cs * Update PackageManagerViewExtensionTests.cs --------- Co-authored-by: pinzart <[email protected]> * changes * remove comment * comments and disable notifications --------- Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]>
To achieve network blackout this is what I had to do: