2.19.1 disable network traffic

src/DynamoApplications/StartupUtils.cs

@@ -411,6 +411,10 @@ private static DynamoModel StartDynamoWithDefaultConfig(bool CLImode,
                 IsServiceMode = isServiceMode,
                 Preferences = PreferenceSettings.Instance
             };
+            config.AuthProvider = CLImode ? null : new Core.IDSDKManager();
+            config.UpdateManager = CLImode ? null : InitializeUpdateManager();
+            config.StartInTestMode = CLImode;
+            config.PathResolver = CLImode ? new CLIPathResolver(preloaderLocation, userDataFolder, commonDataFolder) as IPathResolver : new SandboxPathResolver(preloaderLocation) as IPathResolver;
 
             var model = DynamoModel.Start(config);
             return model;

src/DynamoCore/Logging/AnalyticsService.cs

@@ -84,6 +84,12 @@ internal static bool IsADPOptedIn
 
         internal static bool IsADPAvailable()
         {
+            if (Analytics.DisableAnalytics ||
+                adpAnalyticsUI == null)
+            {
+                return false;
+            }
+
             return adpAnalyticsUI.IsProviderAvailable();
         }
 

src/DynamoCore/Models/DynamoModel.cs

@@ -1111,6 +1111,9 @@ private void CheckFeatureFlagTest()
         {
             if (!DynamoModel.IsTestMode)
             {
+                if (DynamoModel.FeatureFlags == null)
+                    return;
+
                 if (DynamoModel.FeatureFlags.CheckFeatureFlag<bool>("EasterEggIcon1", false))
                 {
                     this.Logger.Log("EasterEggIcon1 is true FROM MODEL");

src/DynamoCore/Scheduler/UpdateRenderPackageAsyncTask.cs

@@ -230,7 +230,7 @@ private void GetTessellationDataFromGraphicItem(Guid outputPortId, IGraphicItem
                 var previousMeshVertexCount = package.MeshVertexCount;
 
                 //Todo Plane tessellation needs to be handled here vs in LibG currently
-                bool instancingEnabled = DynamoModel.FeatureFlags.CheckFeatureFlag<bool>("graphics-primitive-instancing", false);
+                bool instancingEnabled = DynamoModel.FeatureFlags?.CheckFeatureFlag<bool>("graphics-primitive-instancing", false) ?? false;
                 if (graphicItem is Plane plane)
                 {
                     CreatePlaneTessellation(package, plane);

src/DynamoCoreWpf/ViewModels/Menu/PreferencesViewModel.cs

@@ -1114,7 +1114,7 @@ public bool NodeAutocompleteMachineLearningIsBeta
         {
             get
             {
-                return DynamoModel.FeatureFlags.CheckFeatureFlag("NodeAutocompleteMachineLearningIsBeta", false);
+                return DynamoModel.FeatureFlags?.CheckFeatureFlag("NodeAutocompleteMachineLearningIsBeta", false) ?? false;
             }
         }
 

src/DynamoCoreWpf/ViewModels/Watch3D/HelixWatch3DViewModel.cs

@@ -1853,7 +1853,7 @@ internal virtual void AggregateRenderPackages(IEnumerable<HelixRenderPackage> pa
                         //If we have any line geometry that was not associated with an instance,
                         //remove the previously added line data from the render package so the remaining lines can be added to the scene.
                         if (rp.LineVertexRangesAssociatedWithInstancing.Any() 
-                            && DynamoModel.FeatureFlags.CheckFeatureFlag<bool>("graphics-primitive-instancing", false))
+                            && DynamoModel.FeatureFlags?.CheckFeatureFlag<bool>("graphics-primitive-instancing", false) == true)
                         {
                             //For each range of line vertices add the line data and instances to the scene
                             var j = 0;
@@ -1946,7 +1946,7 @@ internal virtual void AggregateRenderPackages(IEnumerable<HelixRenderPackage> pa
                     //If we have any mesh geometry that was not associated with an instance, remove the previously added
                     //mesh data from the render package so the remaining mesh can be added to the scene.
                     if (rp.MeshVertexRangesAssociatedWithInstancing.Any() 
-                        && DynamoModel.FeatureFlags.CheckFeatureFlag<bool>("graphics-primitive-instancing", false))
+                        && DynamoModel.FeatureFlags?.CheckFeatureFlag<bool>("graphics-primitive-instancing", false) == true)
                     {
                         //For each range of mesh vertices add the mesh data and instances to the scene
                         var j = 0;

src/DynamoCoreWpf/Views/Core/DynamoView.xaml.cs

@@ -1348,6 +1348,9 @@ private void CheckTestFlags()
         {
             if (!DynamoModel.IsTestMode)
             {
+                if (DynamoModel.FeatureFlags == null)
+                    return;
+
                 //feature flag test.
                 if (DynamoModel.FeatureFlags?.CheckFeatureFlag<bool>("EasterEggIcon1", false) == true)
                 {

src/DynamoPackagesWPF/PackageManagerViewExtension.cs

@@ -141,6 +141,9 @@ private void RequestLoadViewExtensionsForLoadedPackages(IEnumerable<Package> pac
 
         private void RaisePackageHostNotifications(IEnumerable<Package> packages)
         {
+            // ALIAS does needs a total network traffic blackout.
+            // Since there is no way to switch this on/off, we will just skip it for now.
+            /*
             foreach (var pkg in packages)
             {
                 //check that the package does not target another host, if it does raise a warning.
@@ -157,7 +160,7 @@ private void RaisePackageHostNotifications(IEnumerable<Package> packages)
                         Resources.TitlePackageTargetOtherHost));
                 }
             }
-
+            */
         }
 
         private void RequestLoadLayoutSpecs(IEnumerable<Package> packages)

test/DynamoCoreWpfTests/PackageManagerViewExtensionTests.cs

@@ -239,7 +239,8 @@ public void PackageManagerViewExtesion_TriesToLoadLayoutSpecForBuiltInPackages()
             Assert.AreEqual(Path.Combine(BuiltinPackagesTestDir,"SignedPackage2","extra","layoutspecs.json"), packageManagerViewExtension.RequestedLayoutSpecPaths.FirstOrDefault());
         }
 
-        [Test]
+        // Fails because we are now forcefully disabling host checking because of ALIAS issues. 
+        [Test, Category("Failure")]
         public void PackageManagerViewExtesion_SendsNotificationForPackagesThatTargetDifferentHost_AtExtensionLoad()
         {
             var count = 0;
@@ -271,7 +272,9 @@ void PackageManagerViewExtensionTests_NotificationLogged(NotificationMessage obj
                 count = count + 1;
             }
         }
-        [Test]
+
+        // Fails because we are now forcefully disabling host checking because of ALIAS issues.
+        [Test, Category("Failure")]
         public void PackageManagerViewExtesion_SendsNotificationForPackagesThatTargetDifferentHost_AtLatePackageLoad()
         {
             var count = 0;